Thu, 25 May 2017 01:45:52 +0200 transaction: run _writejournal unfiltered
Pierre-Yves David <pierre-yves.david@octobus.net> [Thu, 25 May 2017 01:45:52 +0200] rev 32452
transaction: run _writejournal unfiltered The function use the length of the repository, something affected by filtering. It seems better to use the unfiltered length here. Credit for finding this goes to Durham Goode.
Mon, 22 May 2017 19:18:12 -0400 bookmarks: warn about bookmark names that unambiguously resolve to a node (BC)
Augie Fackler <augie@google.com> [Mon, 22 May 2017 19:18:12 -0400] rev 32451
bookmarks: warn about bookmark names that unambiguously resolve to a node (BC) I just burned myself on this today because I left out the -r in my `hg bookmark` command, which then left me confused because I didn't notice the bookmark I created in the wrong place that was silently shadowing the revision I was trying to check out. Let's warn the user. This patch only enforces the check on bookmark names 4 characters long or longer. We can tweak that if we'd like, I selected that since that's the fewest characters shortest will use in the templater output. A previous version of this patch rejected such bookmarks. It was proposed during review (and I agree) that the behavior change for a bookmark named "cafe" or similar as history accumulated was a little too weird, but that the warning definitely has merit.
Thu, 04 May 2017 11:51:07 +0900 pycompat: try __bytes__() to convert object to bytestr
Yuya Nishihara <yuya@tcha.org> [Thu, 04 May 2017 11:51:07 +0900] rev 32450
pycompat: try __bytes__() to convert object to bytestr It should be better than using __str__() unconditionally.
Tue, 23 May 2017 15:44:50 +0200 ui: fix ui.configdate for invalid dates
Boris Feld <boris.feld@octobus.net> [Tue, 23 May 2017 15:44:50 +0200] rev 32449
ui: fix ui.configdate for invalid dates a7dce526c462 introduced util._parsedate with the aim to be used in ui.configdate but ui.configdate was using util.parsedate instead. It have the impact of raising an AbortError in case of an invalid date instead of a ConfigError exception. Fix ui.configdate to use the right function and add a test for invalid dates. Thanks to Yuya for the catch!
Fri, 28 Apr 2017 00:01:22 +0900 demandimport: stop overriding __getattribute__()
Yuya Nishihara <yuya@tcha.org> [Fri, 28 Apr 2017 00:01:22 +0900] rev 32448
demandimport: stop overriding __getattribute__() Proxy __dict__ and __doc__ explicitly instead. I'm not sure which is less evil, but this seems slightly simpler than hooking all attribute accesses.
Fri, 28 Apr 2017 23:46:16 +0900 demandimport: look for 'mod' suffix as alternative name for module reference
Yuya Nishihara <yuya@tcha.org> [Fri, 28 Apr 2017 23:46:16 +0900] rev 32447
demandimport: look for 'mod' suffix as alternative name for module reference It's widely used in our codebase.
Mon, 01 May 2017 14:26:56 +0900 demandimport: insert empty line per method
Yuya Nishihara <yuya@tcha.org> [Mon, 01 May 2017 14:26:56 +0900] rev 32446
demandimport: insert empty line per method _demandmod class is getting bigger, and I don't want to put more things in a dense form.
Mon, 01 May 2017 13:43:31 +0900 demandimport: strictly compare identity of proxy object
Yuya Nishihara <yuya@tcha.org> [Mon, 01 May 2017 13:43:31 +0900] rev 32445
demandimport: strictly compare identity of proxy object This looks better, and __eq__() may be overridden in an undesired way.
Tue, 23 May 2017 08:49:01 -0700 match: use ProgrammingError where appropriate
Martin von Zweigbergk <martinvonz@google.com> [Tue, 23 May 2017 08:49:01 -0700] rev 32444
match: use ProgrammingError where appropriate
Tue, 23 May 2017 01:30:36 +0530 revlog: raise error.WdirUnsupported from revlog.node() if wdirrev is passed
Pulkit Goyal <7895pulkit@gmail.com> [Tue, 23 May 2017 01:30:36 +0530] rev 32443
revlog: raise error.WdirUnsupported from revlog.node() if wdirrev is passed When we try to run, 'hg debugrevspec 'branch(wdir())'', it throws an index error and blows up. Lets raise the WdirUnsupported if wdir() is passed so that we can catch that later.
Tue, 23 May 2017 01:22:33 +0530 revset: add support for ancestors(wdir())
Pulkit Goyal <7895pulkit@gmail.com> [Tue, 23 May 2017 01:22:33 +0530] rev 32442
revset: add support for ancestors(wdir()) This is a part of extending support for wdir() predicate.
Tue, 23 May 2017 01:08:19 +0530 revset: add support for using ~ operator on wdir() predicate
Pulkit Goyal <7895pulkit@gmail.com> [Tue, 23 May 2017 01:08:19 +0530] rev 32441
revset: add support for using ~ operator on wdir() predicate We catch the WdirUnsupported exception and handles the wdir() case here.
Mon, 22 May 2017 02:14:22 +0530 revset: add support for p2(wdir()) to get second parent of working directory
Pulkit Goyal <7895pulkit@gmail.com> [Mon, 22 May 2017 02:14:22 +0530] rev 32440
revset: add support for p2(wdir()) to get second parent of working directory This adds support for finding the second parent of working directory using the p2 predicate.
Mon, 22 May 2017 02:03:43 +0530 revset: use try-except instead of if-else because of perf
Pulkit Goyal <7895pulkit@gmail.com> [Mon, 22 May 2017 02:03:43 +0530] rev 32439
revset: use try-except instead of if-else because of perf For wdir(), we now raises an exception which will be raised when wdir() will be passed, so catching that exception is better checking for wdir() using if-else.
Mon, 22 May 2017 01:38:00 +0530 revset: remove redundant condition and change to else from elif
Pulkit Goyal <7895pulkit@gmail.com> [Mon, 22 May 2017 01:38:00 +0530] rev 32438
revset: remove redundant condition and change to else from elif Before going to this piece of code, we already check whether n is in [0, 1, 2], so dropping the redundant condition.
Mon, 22 May 2017 01:35:53 +0530 tests: add tests for predicates and operators which works with wdir()
Pulkit Goyal <7895pulkit@gmail.com> [Mon, 22 May 2017 01:35:53 +0530] rev 32437
tests: add tests for predicates and operators which works with wdir() This one is cluttering up the test file though.
Mon, 22 May 2017 01:01:45 +0530 revset: add support for "wdir()^n"
Pulkit Goyal <7895pulkit@gmail.com> [Mon, 22 May 2017 01:01:45 +0530] rev 32436
revset: add support for "wdir()^n" This patch catches the WdirUnsupported exception raised, and adds support for wdir^n which will give us the nth parent of the working directory.
Mon, 22 May 2017 00:54:02 +0530 revset: add parentheses after wdir since its a function
Pulkit Goyal <7895pulkit@gmail.com> [Mon, 22 May 2017 00:54:02 +0530] rev 32435
revset: add parentheses after wdir since its a function wdir was shown in help rather than wdir().
Mon, 22 May 2017 15:05:18 -0400 cmdutil: avoid redefining write() function in export if possible
Augie Fackler <augie@google.com> [Mon, 22 May 2017 15:05:18 -0400] rev 32434
cmdutil: avoid redefining write() function in export if possible Doing less work inside the loop just feels better to me.
Mon, 22 May 2017 13:34:03 -0400 cmdutil: extract closure that performs the actual export formatting
Augie Fackler <augie@google.com> [Mon, 22 May 2017 13:34:03 -0400] rev 32433
cmdutil: extract closure that performs the actual export formatting This simplifies things a little by making the actual act of turning a revision into patch data a single function. After this, adding formatter support to `hg export` should be much simpler.
Mon, 22 May 2017 13:35:22 -0400 cmdutil: use a generator expression instead of a list comprehension
Augie Fackler <augie@google.com> [Mon, 22 May 2017 13:35:22 -0400] rev 32432
cmdutil: use a generator expression instead of a list comprehension
Sat, 20 May 2017 20:15:05 -0400 cmdutil: rename template param to export to fntemplate
Augie Fackler <augie@google.com> [Sat, 20 May 2017 20:15:05 -0400] rev 32431
cmdutil: rename template param to export to fntemplate It's actually a template for the filename, not a formatter template.
Sat, 20 May 2017 17:58:04 -0400 cmdutil: comprehensively document the interface of export
Augie Fackler <augie@google.com> [Sat, 20 May 2017 17:58:04 -0400] rev 32430
cmdutil: comprehensively document the interface of export I want to make some improvements here, but in order to make future patches easier to review I want to document the current state of the world.
Mon, 22 May 2017 15:56:47 -0700 tests: hide warning from test-xdg.t
Durham Goode <durham@fb.com> [Mon, 22 May 2017 15:56:47 -0700] rev 32429
tests: hide warning from test-xdg.t The test-xdg.t test uses the system hgrc because it unsets HGRCPATH. If the system has an extension enabled that doesn't work with the development version of Mercurial it prints an 'extension failed to load' warning. Let's just hide that by piping stderr to /dev/null.
Mon, 22 May 2017 22:59:40 -0700 policy: define C module versions individually
Jun Wu <quark@fb.com> [Mon, 22 May 2017 22:59:40 -0700] rev 32428
policy: define C module versions individually This allows us to bump the version for a single module without changing all of them.
Sat, 20 May 2017 19:43:58 +0200 repoview: rename '_getdynamicblockers' to 'revealedrevs' (API)
Pierre-Yves David <pierre-yves.david@octobus.net> [Sat, 20 May 2017 19:43:58 +0200] rev 32427
repoview: rename '_getdynamicblockers' to 'revealedrevs' (API) Recent mailing list discussion made me realised we could clarify these. We make the function "public" to encourage extensions to wrap it and we use a more explicit name that mirror "hideablerevs".
Sat, 20 May 2017 19:43:29 +0200 repoview: move '_getdynamicblock' next to 'hideablerevs'
Pierre-Yves David <pierre-yves.david@octobus.net> [Sat, 20 May 2017 19:43:29 +0200] rev 32426
repoview: move '_getdynamicblock' next to 'hideablerevs' There are the two functions that extensions should use to augment the hidding logic. It seem better to have them together at the top of the file.
Sun, 21 May 2017 13:26:17 -0700 python3: allow hgloader to work with lazy loaders
Siddharth Agarwal <sid0@fb.com> [Sun, 21 May 2017 13:26:17 -0700] rev 32425
python3: allow hgloader to work with lazy loaders Don't clobber the loader returned from find_spec. This brings `hg version` down from 0.27 seconds to 0.17.
Sun, 21 May 2017 12:51:01 -0700 init: turn on demandimport for Python 3.6 and above
Siddharth Agarwal <sid0@fb.com> [Sun, 21 May 2017 12:51:01 -0700] rev 32424
init: turn on demandimport for Python 3.6 and above This uses the new demandimport implementation for Python 3 introduced in previous patches. This doesn't yet enhance performance because it isn't integrated with the custom source file loader we use on Python 3. We'll integrate the two in upcoming patches.
Sun, 21 May 2017 12:23:04 -0700 demandimport: add python 3 implementation
Siddharth Agarwal <sid0@fb.com> [Sun, 21 May 2017 12:23:04 -0700] rev 32423
demandimport: add python 3 implementation This implementation uses the new importlib finder/loader functionality available in Python 3.5 and up. # no-check-commit
(0) -30000 -10000 -3000 -1000 -300 -100 -50 -30 +30 +50 +100 +300 +1000 +3000 +10000 tip