Mon, 02 Oct 2017 20:23:25 -0700 zeroconf: do not crash if socket being read is closed by another thread
Jun Wu <quark@fb.com> [Mon, 02 Oct 2017 20:23:25 -0700] rev 34447
zeroconf: do not crash if socket being read is closed by another thread In zeroconf/__init__.py, there is: server = Zeroconf.Zeroconf(ip) l = listener() Zeroconf.ServiceBrowser(server, "_hg._tcp.local.", l) time.sleep(1) server.close() `server.close()` closes the underlying socket while the `ServiceBrowser` may still have a background thread reading the socket. There could be a race condition where the reading thread reads the closed socket, resulting in EBADF crash. This patch catches the exception. This makes test-paths.t pass with chg. Differential Revision: https://phab.mercurial-scm.org/D919
Mon, 02 Oct 2017 19:31:33 -0700 test-revlog-mmapindex: make it compatible with chg
Jun Wu <quark@fb.com> [Mon, 02 Oct 2017 19:31:33 -0700] rev 34446
test-revlog-mmapindex: make it compatible with chg The test misses an explicit flush(). Differential Revision: https://phab.mercurial-scm.org/D918
Mon, 02 Oct 2017 19:10:32 -0700 test-profile: gate chg-incompatible part with '#if chg'
Jun Wu <quark@fb.com> [Mon, 02 Oct 2017 19:10:32 -0700] rev 34445
test-profile: gate chg-incompatible part with '#if chg' chg has a different extension loading logic, which affects the profiler extension test case. Gate the block with '#if chg' so the test passes with chg. Differential Revision: https://phab.mercurial-scm.org/D916
Mon, 02 Oct 2017 18:22:43 -0700 test-logtoprocess: make it compatible with chg
Jun Wu <quark@fb.com> [Mon, 02 Oct 2017 18:22:43 -0700] rev 34444
test-logtoprocess: make it compatible with chg chg runs more commands and outputs more lines. This patch matches them. Differential Revision: https://phab.mercurial-scm.org/D914
Tue, 03 Oct 2017 11:10:03 -0700 test-globalopts: make the test compatible with chg
Saurabh Singh <singhsrb@fb.com> [Tue, 03 Oct 2017 11:10:03 -0700] rev 34443
test-globalopts: make the test compatible with chg The test fails when run with the '--chg' option. Therefore, this commit modifies the test to make it compatible with chg. Test Plan: Ran 'test-globalopts.t' with and without the '--chg' option. Differential Revision: https://phab.mercurial-scm.org/D913
Mon, 02 Oct 2017 16:11:57 -0700 test-pager: make it compatible with chg
Jun Wu <quark@fb.com> [Mon, 02 Oct 2017 16:11:57 -0700] rev 34442
test-pager: make it compatible with chg chg's runpager implementation is different. It behaves differently for the "shell=False, command not found" case. Differential Revision: https://phab.mercurial-scm.org/D911
Mon, 02 Oct 2017 11:03:53 +0100 changelog: use a Factory for default value for files
Gregory Szorc <gregory.szorc@gmail.com> [Mon, 02 Oct 2017 11:03:53 +0100] rev 34441
changelog: use a Factory for default value for files The default value is compiled into the generated type. This means that default values are shared between instances. For immutable types like bool, str, int, and tuple, this is fine. But for mutable types like list and dict, we need to use attr.Factory() to instantiate a new instance of the default for each object. Differential Revision: https://phab.mercurial-scm.org/D901
Mon, 02 Oct 2017 19:28:41 +0100 cext: wrap before brace for functions
Gregory Szorc <gregory.szorc@gmail.com> [Mon, 02 Oct 2017 19:28:41 +0100] rev 34440
cext: wrap before brace for functions This is our prevailing style. Differential Revision: https://phab.mercurial-scm.org/D910
Mon, 02 Oct 2017 19:09:52 +0100 cext: put case statements on separate line
Gregory Szorc <gregory.szorc@gmail.com> [Mon, 02 Oct 2017 19:09:52 +0100] rev 34439
cext: put case statements on separate line This seems to be the prevailing style, even though it is a bit more verbose for very simple switch statements. Differential Revision: https://phab.mercurial-scm.org/D909
Mon, 02 Oct 2017 19:06:00 +0100 cext: reorder #include
Gregory Szorc <gregory.szorc@gmail.com> [Mon, 02 Oct 2017 19:06:00 +0100] rev 34438
cext: reorder #include We mostly abide by this style. In one case, a blank line was inserted to prevent a local `#include "file"` from coming before a `#include <file>`. Differential Revision: https://phab.mercurial-scm.org/D908
(0) -30000 -10000 -3000 -1000 -300 -100 -10 +10 +100 +300 +1000 +3000 +10000 tip