debuginstall: migrate `opts` to native kwargs

debugindexdot: migrate `opts` to native kwargs

debuggetbundle: migrate `opts` to native kwargs

debugformat: migrate `opts` to native kwargs

debugfileset: migrate `opts` to native kwargs

debugextensions: migrate `opts` to native kwargs

debugdiscovery: migrate `opts` to native kwargs

debugdeltafind: migrate `opts` to native kwargs

debugdeltachain: migrate `opts` to native kwargs

debugdata: migrate `opts` to native kwargs

debugcapabilities: migrate `opts` to native kwargs

debugbundle: migrate `opts` to native kwargs This is a utility function that's only called by `debugbundle()`. The rest of the command was previously ported.

branching: merge with stable

tags: avoid expensive access to repo.changelog in a loop repo.changelog needs some cache invalidation when run on filtered repository. Accessing it in that loop can be expensive when there is many heads (e.g. mozilla try and it 25 000 heads). Note that the loop itself seems useless, but after this patch it no longer take about ⅛ of the time we spend computing cache for mozilla try. before : ! wall 0.350994 comb 0.350000 user 0.330000 sys 0.020000 (median of 28) after : ! wall 0.319520 comb 0.310000 user 0.290000 sys 0.020000 (median of 30)

blackbox: add a option to duplicate output to stderr too This is useful when debugging some performance operation.

perf: add a --update-last flag to perf::tags See inline documentation for details.

perf: add a `--clear-fnode-cache-rev` argument to perf::tags This will help us test this in situation closer to an update after a commit or a push.

perf: introduce more cache invalidation option in perf::tags This will help us to assert the performance of different versions in more diverse situations. We introduce helper function in the tags module in case invalidating such cache becomes different in the future.

hgweb: pass strings in WSGI environment correctly from wsgicgi According to PEP 3333, the strings in the WSGI environment must be translatable to bytes using the ISO-8859-1 codec.

branching: merge stable into default

Added signature for changeset 5a8b54201039

Added tag 6.5.2 for changeset 5a8b54201039

relnotes: add 6.5.2

run-tests: detect HGWITHRUSTEXT value Without this, some manual check in tests/test-dirstate.t could get confused by the lack of `rust` in module policy and break the test.

tests: avoid test environment affecting setup.py In particular [RHG_FALLBACK_EXECUTABLE] is being set prematurely, before rhg is built, but probably the rest of the env changes don't help, either.

setup: make the error "Unable to find a working hg binary" more informative The error message now shows the attempted hg commands and their stderr, to make it easier to investigate why things are not working. Here's an example output /!\ /!\ Unable to find a working hg binary /!\ Version cannot be extracted from the repository /!\ Re-run the setup once a first version is built /!\ Attempts: /!\ attempt #0: /!\ cmd: ['hg-missing', 'log', '-r.', '-Ttest'] /!\ exception: [Errno 2] No such file or directory: 'hg-missing': 'hg-missing' /!\ attempt #1: /!\ cmd: ['/usr/bin/python3', 'hg', 'log', '-r.', '-Ttest'] /!\ return code: 255 /!\ std output: /!\ std error: *** failed to import extension "topic": No module named 'topic' *** failed to import extension "evolve": No module named 'evolve' abort: accessing `dirstate-v2` repository without associated fast implementation. (check `hg help config.format.use-dirstate-v2` for details) /!\ /!\ Could not determine the Mercurial version /!\ You need to build a local version first /!\ Run `make local` and try again /!\

pycompat: drop usage of hasattr/getattr/setattr/delatt proxy The function remains to ease extensions transition, but we no longer use them in core.

safehasattr: drop usage in favor of hasattr The two functions should now be equivalent at least in their usage in core.

check-code: drop the `safehasattr` rule Since we no longer supports Python 2 we no longer needs to use a custom function to compensate the short comings of the global `hasattr` function in it. We cannot use the Python 3 `hasattr` function instead.

url: ignore some future pytype error As soon as we start using the builtins `hasattr` function, pytype will start getting confused about which types are available or not. So we ignore this error beforehand.

url: move the _generic_proxytunnel in the `has_https` block It is only used when https exists. If you stay out of the block, pytype complains that the type of its argument are not declared.

pycompat: deprecate using bytes Python2 has been dropped for a while, so lets comply to the signature of the global function. This open the way to drop the use of `pycompat.getattr` and company, and, especially, the associated `util.safehasattr`.

dynamic-import: use sysstr for importing extension and others This logic is used by extensions, and python hooks and merge-tools. All this logic eventually deals with native string (unicode in Python 3). This patch makes it handle `str` directly instead of relying on some pycompat low lever layer to do the conversion at the last minutes. We adjust the Python version filtering of a test as the output seems to be present with Python 3.7 too.

extension: check the command attributes using `sysstr` Since we are checking attributes, lets use the native representation instead of bytes.

extension: access special module members using sysstr These extensions variables and mapping are module attributes so they should be dealt with unicode `str` in Python 3. We move the part that deal with reading theses variable and checking their validity to use unicode `str` string.

sshpeer: convert command name to sysstr before accessing method Method name are `str` so we should pass them as `str`.

localrepo: purge filecache attribute using there unicode name This could be better, but that's a good step.

fastannotate: use sysstr to check for attribute presence We do not need bytes here.

fastannotate: use sysstr to deal with some attributes We are now Python3 only and attribute are always unicode string. So no needs to managed them using bytes.

hgweb: use sysstr to set attribute on diff option Attribute identifier should be `str` not `bytes`.

hgweb: use sysstr to get attribute on diff option Attribute identifier should be `str` not `bytes`.

diff-option: move attributes handling to sysstr Attributes are `str` and should be handled as such.

compression: use sysstr to specify attribute to fetch for priority These are attributes so they should be `str`.

smartset: set attribute using sysstr instead of bytes We do not needs bytes here.

cachedlocalrepo: use sysstr for attribute name of "file of interest" The first item is an attribute name, the second one is a filename. So the first one can (and should) be a `str`.

terse-status: use `sysstr` to specify attributes to set We use unicode string to specify attribute and we add a explicit char for the other usage.

path-suboption: deprecated specifying the attributes as bytes The known suboptions have been updated, so we can deprecated passing bytes in case some extensions use them.

path-suboption: use str for "_pushloc" suboptions That second argument refer to an attribute and do not needs to be bytes.

path-suboption: use str for "pushrev" suboptions That second argument refer to an attribute and do not needs to be bytes.

path-suboption: use str for "bookmarks_mode" suboptions That second argument refer to an attribute and do not needs to be bytes.

path-suboption: use str for "delta_reuse_policy" suboptions That second argument refer to an attribute and do not needs to be bytes.

path-suboption: use str for "multi_urls" path suboptions That second argument refer to an attribute and do not needs to be bytes.

convert: use sysstr to check for attribute presence We do not need bytes here.

mq: use sysstr to check for attribute access We do not need bytes here.

lfs: use sysstr to check for attribute presence We do not need bytes here.

mq: use sysstr to check for attribute presence We do not need bytes here.

relink: use sysstr to check for attribute presence We do not need bytes here.

ui: use sysstr to check for attribute presence We do not need bytes here.

remotefilelog: use sysstr to access for attributes We do not need bytes here.

hgwebmod: use sysstr to check for attribute presence We do not need bytes here.

remotefilelog: use sysstr to check for attribute presence We do not need bytes here.

extensions: use sysstr to check for attribute presence We do not need bytes here.

bundle2: use sysstr to check for attribute presence We do not need bytes here.

largefile: use sysstr to check for attribute presence in `hgsubrepoarchive` We do not need bytes here.

largefile: use sysstr to check for attribute presence in `openstore` We do not need bytes here.

largefile: use sysstr to check for attribute presence in `rebase` wrapping We do not need bytes here.

largefile: use sysstr to check for attribute presence in `getstatuswriter` We do not need bytes here.

run-tests: detect HGWITHRUSTEXT value Without this, some manual check in tests/test-dirstate.t could get confused by the lack of `rust` in module policy and break the test.

convert: stabilize subversion date sorter In case of tie, this provides unstable result on my system. So I am adding a couple of tie breaker to fix the test.

rhg: allow setting defaults.cmd to an empty string This is used by at least one hg UI to prevent defaults from affecting the command: https://github.com/emacs-mirror/emacs/blob/b71beb7ae7c60a5c5af608420d28fdda5265a264/lisp/vc/vc-hg.el#L245 Let's let it work.

uncommit: migrate `opts` to native kwargs

split: migrate `opts` to native kwargs

releasenotes: migrate `opts` to native kwargs

narrow: hoist a variable to a higher level to avoid use-before-init warning In practice, this shouldn't generate an IOError, so there wouldn't have been a problem. But PyCharm didn't know that.

narrow: migrate `opts` to native kwargs

largefiles: migrate `opts` to native kwargs

keyword: migrate `opts` to native kwargs

gpg: use a context manager to write `.hgsigs`

gpg: migrate `opts` to native kwargs

fetch: migrate `opts` to native kwargs

fastexport: migrate `opts` to native kwargs

closehead: wrap transaction handling in a context manager

closehead: migrate `opts` to native kwargs

churn: migrate `opts` to native kwargs

children: migrate `opts` to native kwargs

automv: migrate `opts` to native kwargs

absorb: migrate `opts` to native kwargs

transaction: fix __repr__() and make the default name bytes This likely was always wrong on py3, since going back to aff5996f3043, these were added as a r-strings. Callers seem to always be supplying bytes, which makes the `b'/'.join(...)` part OK, but then bytes can't be interpolated into str with "%s", so it wouldn't have worked in either case.

rhg: support rhg files [FILE] This comes mostly for free after the rhg status [FILE] implementation.

rhg: support "status FILE" This change adds a new [file] argument to rhg status, parses them as patterns, canonicalizes the paths, and constructs a new PatternMatcher to intersect with the existing matcher being passed to the status implementation. We also make filepatterns a public module so we can access the pattern-parsing functionality we need from commands/status.rs.

rust-matchers: add PatternMatcher This should match the behavior of the Python patternmatcher. We need this for status [FILES] support.

rust-status: only visit parts of the tree requested by the matcher This is an optimization that the matcher is designed to support, but we weren't doing it until now. This is primarily relevant for supporting "hg status [FILES]", where this optimization is crucial for getting good performance (without this optimization, that command will still scan the entire tree, and just filter it down after the fact). When this optimization fires we have to return false from traverse_fs_directory_and_dirstate, representing that that part of the tree *might* have new files which we didn't see because we skipped parts of it. This only affects the cached result of the status, and is necessary to make future status operations (which might use a different matcher) work properly.

rust-status: error on non-existent files in file_set file_set here consists of the files that were explicitly specified on the command line. Erroring on them matches the behavior of Python status.

rust-status: explicitly track bad file types Before this, we silently skipped bad file types. Now, we check to see if a path is an exact_match in our matcher, and if so, print an error for it, and only then do we skip it. A path will be an exact match when it's specified as an explicit command line argument, and this error-printing behavior is necessary for compatibility with Python status.

rust: de-hardcode glob_suffix We're adding patternmatcher in a subsequent commit, and this needs needs to be different for includematcher and patternmatcher.

rust: improve the type on DirsMultiset::from_manifest It could only return an HgPathError, but we didn't express this in the type, so we needed some unreachable!()s. Now that is expressed in the type.

rust: don't escape spaces in regex Spaces are not in fact a regex special character, and escaping them is not correct.

rust-filepatterns: also normalize RelPath These patterns should be normalized too; this at least does no harm, and is necessary for proper status support.

rust: simplify pattern file parsing Previously we kept the pattern syntax as a &[u8] until the last possible moment, which meant we had to handle potential errors when parsing that &[u8]. But such errors could never actually occur, given the structure of the code. Now we parse it eagerly (in two places) and pass it around as a PatternSyntax, so we can delete some error handling code. parse_one_pattern is in particular useful for parsing patterns passed on the command line, as we'll support later in this series.

rust-matchers: better support file_set in IntersectionMatcher Previously, if both of the input matchers had non-exact file sets, IntersectionMatcher would simply have an empty fileset. Now, we duplicate Python behavior: we *union* the filesets of the matchers in that case. This makes some sense, because without exact input file sets, we can't do an exact intersection and must over-approximate. Concretely, this is necessary because the file_set is the list of files that were explicitly listed by the user, and we want to provide explicit errors for all such files, from both matchers.

branching: merge stable into default

version: migrate `opts` to native kwargs

verify: migrate `opts` to native kwargs

tags: migrate `opts` to native kwargs

tag: migrate `opts` to native kwargs

summary: migrate `opts` to native kwargs This has the added benefit of unconfusing PyCharm- it thought `opts` in the nested functions were str based for some reason.

revert: migrate `opts` to native kwargs

rename: drop an unnecessary variable declaration at a wider scope

rename: migrate `opts` to native kwargs

remove: migrate `opts` to native kwargs

purge: migrate `opts` to native kwargs

pull: avoid referencing a variable before it is initialized If `urlutil.get_pull_paths()` somehow yields nothing, the reference after the loop appears to be a problem. I noticed this because PyCharm flagged (and still flags) the initialization of this inside the loop as somehow unused. I'm not sure why 1 isn't returned directly where it is set to the result of `postincoming()`, but maybe the code is structured this way in anticipation of future work.

pull: migrate `opts` to native kwargs

paths: migrate `opts` to native kwargs

merge: migrate `opts` to native kwargs

manifest: migrate `opts` to native kwargs

locate: migrate `opts` to native kwargs

import: migrate `opts` to native kwargs

heads: migrate `opts` to native kwargs

forget: migrate `opts` to native kwargs