merge: use separate lists for each action type This replaces the grand unified action list that had multiple action types as tuples in one big list. That list was iterated multiple times just to find actions of a specific type. This data model also made some code more convoluted than necessary. Instead we now store actions as a tuple of lists. Using multiple lists gives a bit of cut'n'pasted code but also enables other optimizations. This patch uses 'if True:' to preserve indentations and help reviewing. It also limits the number of conflicts with other pending patches. It can trivially be cleaned up later.

changelog: ensure changelog._delaybuf is initialized The ``localrepo.writepending`` method is using the ``changelog._delaybuff`` attribute to know if it has anything to do. However the ``changelog._delaybuff`` is never initialised at ``__init__`` time. This can lead to crash when using bundle2 for part that never touch the changelog. We simply initialize it to its base value. This is scheduled for stable as it both trivial and blocking for experimenting with bundle2.

proxy: remove unneeded _set_hostport for compatibility with Python 2.7.7rc1 With Python 2.7.7rc1, "hg pull" through HTTP CONNECT tunnel fails due to the removal of _set_hostport [1]. ... File "mercurial/url.py", line 372, in https_open return self.do_open(self._makeconnection, req) ... File "mercurial/url.py", line 342, in connect _generic_proxytunnel(self) File "mercurial/url.py", line 228, in _generic_proxytunnel self._set_hostport(self.host, self.port) AttributeError: httpsconnection instance has no attribute '_set_hostport' self._set_hostport(self.host, self.port) should be noop and can be removed because: - _set_hostport() [2] was the function to parse "host:port" string and set them to self.host and self.port, - and (self.host, self.port) pair should be valid since connect() is called prior to _generic_proxytunnel(). [1]: http://hg.python.org/cpython/rev/568041fd8090 [2]: http://hg.python.org/cpython/file/3a1db0d2747e/Lib/httplib.py#l721

bugzilla: support Bugzilla 4.4.3+ API login token authentication (issue4257) Bugzilla 4.4.3 and later remove the old cookie based session authentication from the Web Services API and replace it with a login token. The session can now also be restricted to the originating IP. Add the necessary to the extension so it works with 4.4.3 and later.

resolve: don't abort resolve -l even when no merge is in progress This broke some internal automation that was quite reasonably checking for unresolved files as a way to determine whether a merge happened cleanly. We still abort for resolve --mark etc.

templates: fix ifcontains against sets with length > 1 (issue4259) Previously the ifcontains revset was checking against the set using a pure __contains__ check. It turns out the set was actually a list of formatted strings meant for ui output, which meant the contains check failed if the formatted string wasn't significantly different from the raw value. This change makes it check against the raw data, prior to it being formatted.

run-tests: assign value to ESCAPEMAP - dict.update do not return self a36cc85a5b7b did more than what the description said and introduced a bug.

run-tests: fix invalid reference to stringescape after a36cc85a5b7b

update: specify custom conflict markers for update (BC) Add custom conflict markers 'working copy' and 'destination' for doing hg update when there are conflicts between your working copy and the destination.

run-tests: add docstrings

run-tests: avoid duplicate code in vlog()

run-tests: make attributes of TestRunner internal There is little reason for the data members of TestRunner to be public, as they are implementation details. Enforce it through naming.

run-tests: make testdir an argument of TestSuite.__init__ With this change, TestSuite no longer accesses anything on TestRunner and the TestRunner is no longer passed to TestSuite.

run-tests: move loop to a named argument of TestSuite.__init__

run-tests: make keywords a named argument to TestSuite.__init__ This was the last usage of option in ``TextTestRunner.run``.

run-tests: make retest a named argument of TestSuite.__init__

run-tests: move whitelist and blacklist to named arguments of TestSuite

run-tests: pass jobs into TestSuite constructor This starts a series of patches that will lessen the importance of TestRunner. It will remove the TestRunner instance stored inside the TestSuite.

help: add local/other description to merge tool description Adds a more detailed description of what 'local' and 'other' mean to the merge tool documentation.

rebase: specify custom conflict marker labels for rebase (BC) Changes rebase conflict markers to say 'source' and 'dest' instead of 'local' and 'other'. This ends up looking like: one <<<<<<< dest: a3e5c7fd master - bob: "A commit to master" master ======= mine >>>>>>> source: c7fda3e5 - durham: "A commit to my feature branch" three

graft: customize graft conflict markers (BC) Changes the graft conflict markers to be 'graft' and 'local' to make it more intuitive which side is which.

merge: add labels parameter from merge.update to filemerge Adds a labels function parameter to all the functions between merge.update and filemerge.filemerge. This will allow commands like rebase to specify custom marker labels.

run-tests: move interactive test acceptance into TestResult We shouldn't be performing interactive prompting during test execution. The first step of this is to move the functionality into TestResult.

run-tests: raise WarnTest outside of Test.fail()

run-tests: move diff generation into TestResult TestResult is the thing that captures all our test results. It's logical for diff viewing to be handled there and not inside Test. While writing this patch, it was discovered that Test.fail() was printing redundant test result output. This has been removed. Arguments controlling diffs have been removed from Test.__init__.

run-tests: remove global abort flag The global abort flag has been moved into each Test instance. A Test.abort() accomplishing the same thing has been added.

merge: add conflict marker formatter (BC) Adds a conflict marker formatter that can produce custom conflict marker descriptions. It can be set via ui.mergemarkertemplate. The old behavior can be used still by setting ui.mergemarkers=basic. The default format is similar to: {node|short} {tag} {branch} {bookmarks} - {author}: "{desc|firstline}" And renders as: contextblahblah <<<<<<< local: c7fdd7ce4652 - durham: "Fix broken stuff in my feature branch" line from my changes ======= line from the other changes >>>>>>> other: a3e55d7f4d38 master - sid0: "This is a commit to master th... morecontextblahblah

run-tests: remove options from Test.__init__ All options are now passed as arguments and we no longer need options. This enables us to instantiate Test from "plain old data" types. Since options must be given as arguments, it also makes people think harder about adding things that may not belong in Test. This will help ensure a proper separation of responsibility going forward.

run-tests: move shell to Test.__init__

run-tests: move py3kwarnings to Test.__init__

run-tests: move extra config options to Test.__init__

run-tests: refactor port number declaration Instead of making port numbers derived from count and a global initial port, we now pass a start port to Test.__init__ and do the calculation at a higher level.

run-tests: move timeout into Test.__init__

run-tests: move interactive to Test.__init__

run-tests: move diff options into arguments of Test.__init__

run-tests: move debug into an argument to Test.__init__

run-tests: factor options.keep_tmpdir into an argument to Test.__init__

run-tests: remove redundant test name filter TestSuite.run() doesn't need to filter tests by name because that already happens elsewhere. Garbage in garbage out applies.

run-tests: move test filtering into TestSuite.run() Upcoming patches will move the execution of tests to separate processes. To facilitate this, it makes sense to move logic out of Test. Furthermore, test filtering is logically the domain of the test runner, not the test itself. This patch interrupts our mini series of factoring options into named arguments because filtering consults many options and it is easier to move this logic out of Test sooner so we don't have to introduce arguments at all.

run-tests: no longer pass a TestRunner into Test.__init__ We no longer access any attributes on TestRunner besides options, so we stop passing a TestRunner to Test.__init__ and now pass the options data structure instead. Subsequent patches will move accessed options attributes into named arguments.

run-tests: pass abort into Test.__init__

run-tests: pass temp dir into Test.__init__ This patch starts a mini series of moving arguments to Test.__init__ from semi-complex data structures (such as the command options) to named arguments. This will allow Test instances to be more easily instantiated from other contexts. This improves the ability to run Mercurial tests in new and different environments.

update: show message when a bookmark is activated by update When updating to a bookmark, mention that the bookmark is now active. This is a reminder that update does not move the current bookmark if an explicit target is given - instead it activates that target.

run-tests: pass a full test path into Test.__init__ Previously, a Test's path came from the base directory of all tests and a filename leaf. There is not a strong reason why an absolute test path can not be specified. This change isn't strictly necessary. But it does enable scenarios such as more easily running tests from multiple, non-sibling directories.

run-tests: factor refpath into Test classes refpath is a side-effect of the test type. We therefore move it to the Test class implementations.

run-tests: don't trap exceptions in Test.runTest() Exceptions are all handled in Test.run(). This code was redundant since the unittest test wrapper class was merged into Test.

run-tests: factor options out of run() We were only utilizing 2 parts of options. These have been converted to named arguments.

convert: mercurial source: convert global tags only - not local tags Mercurial tags can be local (tag -l, stored in .hg/localtags) or global (normal tags, tracked in .hgtags) ... or extensions can add other kind of tags. Convert would take all tags (except "tip"), not just the ones from .hgtags, and put them into .hgtags. Instead, convert only the global tags that come from .hgtags.

run-tests: refactor temporary directories in Test We no longer need cleanup() because setUp() and tearDown() cover it. We move tempdir creation into setUp() and always delete in tearDown()

run-tests: move _executetests into TestSuite

run-tests: capture execution times in TestResult TestResult has facilities for recording when tests start and stop. It makes sense to move execution time recording into TestResult. In addition, output generation is being moved into TestResult, a class that has a concept of an output buffer (and a lock).

run-tests: move outputtimes() into unittest runner class The unittest runner now does all the printing. Move outputtimes() there.

run-tests: refactor how times are recorded We now record times in Test.run(), which is a more appropriate place for it.

run-tests: eliminate Test._result The result of test execution is now reported on a TestResult. We no longer need to store a tuple of the result.

run-tests: replace Test.ignore() with raise IgnoreTest

run-tests: replace Test.skip() with raise SkipTest All the result functions now raise an Exception. We no longer need these functions and we can inline the raise.

run-tests: remove some legacy code around result handling unittest handles all results now. We no longer need to manually keep track of results.

run-tests: merge MercurialTest into Test Now that we execute all tests via unittest, the MercurialTest wrapper is not necessary. This patches moves the logic from MercurialTest into Test and makes Test a child of unittest.TestCase.

check-code: check for consistent usage of the websub filter in hgweb templates The check-code tool now expects the "desc" keyword to be followed by the "websub" filter, with the following exceptions: a) It has no filters at all, e.g. a changeset description in the raw style templates or the repository description in the summary page. b) It is followed by the "firstline" filter, e.g. the first line of the changeset description is displayed as a summary or title.

hgweb: apply websub filter to the changeset description in rss and atom feeds For example, this is useful for linking from the feed reader to a bug tracker. This follows the existing pattern used within the hgweb templates. With the exception of the raw style, all usages of the changeset "desc" keyword are now followed by either the "firstline" filter or the "websub" filter. When "websub" is used, it always follows the "escape" filter.

tests: write the hgrc file for test-hgweb-commands.t with cat instead of echo To improve the readability.

tests: tests for the rss feeds This matches the existing tests for the atom feeds.

localrepo: use _matchstatus of context objects Now that we have the machinery in place, we call the context method for changing the match object in the case of comparing the working directory with its parent. This removes the last of the hard-coded workingctx knowledge in localrepo paving the way for us to remove localrepo.status completely.

workingctx: override _matchstatus for parentworking case This patch encapsulate the logic for changing the match.bad function when comparing against the working directory's parent. Future patches will remove more of the 'if ... else' blocks in localrepo.status that test for this working directory parent case.

basectx: add _matchstatus method for factoring out last of parentworking logic This patch paves the way to allow a workingctx to override the match object with a custom 'bad' method for cases where status is sent a directory pattern.

workingctx: use inheritance for _buildstatus while keeping the fastpath This patch maintains the fast path for workingctx which is to not build a manifest if the working directory is being compared to its parent since, in this case, we can just copy the parent manifest.

localrepo: remove unneeded unpacking of r This unpacking is unneeded now because previous patches have removed the need for this method to modify each of these variables in favor of passing the whole set around to pre/post hook methods of the corresponding context object.

localrepo: call _poststatus hook instead of hardcoding symlink knowledge

workingctx: add _poststatus method to call _filtersuspectsymlink With this patch, we are one step closer to removing 'if ... else' logic in localrepo.status for testing if the context is the working directory or not. Future patches will replace those blocks of code with a call to the context's _poststatus hook so that each context object will do the right thing depending on the situation.

context: add a no-op _poststatus method This patch adds a private _poststatus method so that certain contexts, such as workingctx, can add custom post-processing to status.

localrepo: call _prestatus hook instead of hardcoding dirstate knowledge

workingctx: add _prestatus method to call _dirstatestatus With this patch, we are one step closer to removing 'if ... else' logic in localrepo.status for testing if the context is the working directory or not. Future patches will replace those blocks of code with a call to the context's _prestatus hook so that each context object will do the right thing depending on the situation.

context: add a no-op _prestatus method This patch adds a private _prestatus method so that certain contexts, such as workingctx, can add custom pre-processing to status.

localrepo: use _buildstatus from context

context: add _buildstatus method This method is a copy of localstatus.status's core logic. Later patches will clean up some of the dense coditionals in the for loop.

localrepo: remove workingctx logic already moved to context

localrepo: move the order of local variables This movement is a small step in getting rid of the 'if ... else' logic for testing the current working directory with its parent. Previously, the deleted, unknown, and ignored variables were set in a combination of before an 'if ... else' block and within the block. This moves the variables to be set outside the loop in one common place.

localrepo: factor out _manifestmatch logic for workingctx

localrepo: use _manifestmatches instead of duplicating logic

basectx: add _manifestmatches method This method is a duplicate of localrepo.mfmatches and sets the stage for factoring localrepo.status into a context method that will be customizable based on inheritance and object type.

localrepo: always set the variable r in status method This is a small patch to help streamline keeping tracking of the list of files for status in a variable already called 'r' ('s' is for subrepos in this method). We now move the setting of it out of an 'if' block so that we can later refactor more code into the context objects.

run-tests: execute tests via unittest Now that unittest mode is functionally equivalent to the default mode, we switch the default execution mode to unittest and remove the choice of different execution modes.

run-tests: implement Test.__str__ unittest sometimes does a str(test) and the default implementation doesn't do the right thing. So we override it.

run-tests: make failure reporting in unittest mode equivalent to default Unlike unittest's defaults, our result formatter does not print stack traces. Here, we change TestResult.addFailure() to be compatible with the existing/default execution mode.

run-tests: ignore failures from rmtree rmtree() may fail under certain conditions. We ignore failures at the individual test level because they can interfere with test execution. Furthermore, we'll reattempt deletion in the high-level test runner after all tests have finished. Note that this patch is not a code refactor like most of the patches before it. This change logically makes sense given the execution behavior of the tests.

run-tests: abort tests after first failure in unittest mode There is an execution mode on run-tests.py that stops after the first failure. unittest mode was previously not obeying this option. This patch fixes that.

run-tests: print compatible output from TextTestRunner Our unittest TextTestRunner now prints output similar to the output from the default execution mode - the output people expect from run-tests.py.

run-tests: don't print results in unittest mode A subsequent patch will have unittest print tests for us. Don't perform old-style printing when in unittest mode.

run-tests: move errpath deletion to setUp()

run-tests: kill daemons during tearDown()

run-tests: move err file writing to tearDown()

run-tests: refactor testtmp testtmp is now a member variable of our test class. It's value is computed during instance creation and the directory is managed via the lifetime of the test object.

run-tests: store skipped state on Test As code is being moved between functions, we need a member variable to hold skipped state.

run-tests: move some functionality to Test.tearDown()

run-tests: store last result in Test._result Subsequent patches move post-test actions into tearDown(). This requires tearDown() to have access to the last result.

run-tests: report test duration in Test.tearDown()

run-tests: store test return code and output in Test instance A subsequent patch that will introduce tearDown() requires test execution state be stored in the instance.

run-tests: keep track of test start and stop in MercurialTest.run() This brings run() more compatible with unittest.TestCase.run()

run-tests: keep track of test execution state in Test This patch starts a mini series of moving functionality into the newly-established setUp() and tearDown() methods.

run-tests: support setUp() and tearDown() in TestCase wrapper unittest.TestCase.run() calls setUp() and tearDown() during run(). We emulate that implementation.

run-tests: fail tests by raising an exception When in unittest mode, Test.run() will now raise for all non-success cases. This makes it behave like TestCase.run().

run-tests: record warnings by raising WarnTest We continue the conversion of recording test results by raising exceptions.

run-tests: record ignored tests by raising IgnoreTest

run-tests: record skips by raising SkipTest The unittest way of recording a skipped test is to raise an exception (at least with modern unittest implementation). We change Test to raise a SkipTest when operating in unittest mode. This does prevent some "tear down" activities from running in unittest mode. This will be fixed in subsequent patches. Since unittest mode is experimental, this should be OK.

run-tests: implement TestCase.run() Simply wrapping TestCase.run() is not sufficient for robust results reporting because unittest in Python 2.4 does not know about things like skipped tests and reports them as success or failures instead of skips. We will reimplement TestCase.run() with knowledge and semantics present in modern Python releases.

run-tests: don't print progress from Test when in unittest mode unittest does its own printing of progress indicators as part of TestResult. So, there is no need to print them when running in unittest mode. This will fix the double output of progress indicators that had been occurring in unittest mode.

run-tests: define a custom TestSuite that uses _executetests() We now have a custom unittest.TestSuite implementation that uses _executetests() and thus knows how to execute tests concurrently. Running tests in --unittest mode will use this TestSuite. Since the TestSuite handles concurrency, the warnings around --jobs and --loop have been removed.

run-tests: pass an optional TestResult into _executetests() If the result is passed, we execute tests in the unittest way. A subsequent patch will actually do this.

run-tests: pass Test instances into TestRunner._executetests() Test instances (not paths) are passed into _executetests(). This means the logic for instantiating Test instances has been moved outside of _executetests(). This was done because an upcoming patch will reuse the logic in _executetests(). As part of this change, test counts are no longer managed by _executetests().

run-tests: define cleanup() on unittest class We need a cleanup() on our unittest TestCase class to conform with the execution API. This will eventually be replaced by tearDown().

run-tests: rename Test._test to Test.name A lot of the attributes in Test could probably be renamed. This one is needed for an upcoming patch.

run-tests: teach Test instances whether they are in unittest mode Tests executing in unittest mode behave a little differently. For example, they report their results to a TestResult rather than just printing. This patch paves the way for better integration of Test into the unittest framework.

run-tests: teach unittest about warned results

run-tests: document how success code is handled

run-tests: teach unittest about ignored tests

run-tests: teach unittest about skipped tests

run-tests: define custom result and runner classes for unittest We need to teach unittest about some custom result types. This will require some custom classes. This patch creates a skeleton for them.

run-tests: start to report test results against TestResult Previously, our unittest wrapper didn't report results properly. We now properly report failures. We had to rename the local variable to prevent "t" from being overwritten in the local scope.

run-tests: give unittest wrapper a short description This will make the output contain something useful rather than the default repr() for the class.

run-tests: initial support for running tests with unittest The unittest package in Python's standard library provides an almost universal mechanism for defining and running tests. This patch starts the process of making run-tests.py talk to it. The main benefit of speaking unittest is that this will enable Mercurial's tests to be more easily consumed by other testing tools, like nose. This is useful for 3rd party extensions having their own test infrastructure, for example. Running tests in unittest mode will not result in completely sane behavior until the unittest mode is made the default execution mode. Expect things like double printing of output until support stabilizes.