hgext/narrow/TODO.rst
author Gregory Szorc <gregory.szorc@gmail.com>
Tue, 11 Sep 2018 15:53:12 -0700
changeset 39544 10a8472f6662
parent 36104 9b5df6e19a4f
child 39771 a063786c89fb
permissions -rw-r--r--
narrow: drop support for remote expansion (BC) Previous patches to validate narrow patterns accidentically dropped support for the include: syntax that allows patterns to be expanded from a remote. This feature was never implemented in core and is only implemented on Google's custom server. Per @martinvonz's review comment in D4522, it is OK to drop this feature since it isn't used. The concept of this feature does seem useful. I anticipate it making a comeback some day in some shape or form. But for now, let's jettison the dead code. Differential Revision: https://phab.mercurial-scm.org/D4530

Integration with the share extension needs improvement. Right now
we've seen some odd bugs, and the way we modify the contents of the
.hg/shared file is unfortunate. See wrappostshare() and unsharenarrowspec().

Resolve commentary on narrowrepo.wraprepo.narrowrepository.status
about the filtering of status being done at an awkward layer. This
came up the import to hgext, but nobody's got concrete improvement
ideas as of then.

Fold most (or preferably all) of narrowrevlog.py into core.

Address commentary in narrowrevlog.excludedmanifestrevlog.add -
specifically we should improve the collaboration with core so that
add() never gets called on an excluded directory and we can improve
the stand-in to raise a ProgrammingError.

Figure out how to correctly produce narrowmanifestrevlog and
narrowfilelog instances instead of monkeypatching regular revlogs at
runtime to our subclass. Even better, merge the narrowing logic
directly into core.

Reason more completely about rename-filtering logic in
narrowfilelog. There could be some surprises lurking there.

Formally document the narrowspec format. Unify with sparse, if at all
possible. For bonus points, unify with the server-specified narrowspec
format.

narrowrepo.setnarrowpats() or narrowspec.save() need to make sure
they're holding the wlock.