phases: keep internal state as rev-num instead of node-id Node-id are expensive to work with, dealing with revision is much simple and faster. The fact we still used node-id here shows how few effort have been put into making the phase logic fast. We tend to no longer use node-id internally for about ten years. This has a large impact of repository with many draft roots. For example this Mozilla-try copy have ½ Million draft roots and `perf::unbundle` see a significant improvement. ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # benchmark.name = hg.perf.perf-unbundle # bin-env-vars.hg.flavor = no-rust # bin-env-vars.hg.py-re2-module = default # benchmark.variants.issue6528 = disabled # benchmark.variants.revs = last-1 before:: 1.746791 seconds after:: 1.278379 seconds (-26.82%) # benchmark.variants.revs = last-10 before:: 3.145774 seconds after:: 2.103735 seconds (-33.13%) # benchmark.variants.revs = last-100 before:: 3.487635 seconds after:: 2.446749 seconds (-29.85%) # benchmark.variants.revs = last-1000 before:: 5.007568 seconds after:: 3.989923 seconds (-20.32%)

     1

  $ NO_FALLBACK="env RHG_ON_UNSUPPORTED=abort"

     2

     3

  $ cat << EOF >> $HGRCPATH

     4

  > [format]

     5

  > sparse-revlog = no

     6

  > EOF

     7

     8

  $ hg init repo --config format.generaldelta=no --config format.usegeneraldelta=no

     9

  $ cd repo

    10

  $ (echo header; seq.py 20) > f

    11

  $ hg commit -q -Am initial

    12

  $ (echo header; seq.py 20; echo footer) > f

    13

  $ hg commit -q -Am x

    14

  $ hg update ".^"

    15

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    16

  $ (seq.py 20; echo footer) > f

    17

  $ hg commit -q -Am y

    18

  $ hg debugdeltachain f --template '{rev} {prevrev} {deltatype}\n'

    19

  0 -1 base

    20

  1 0 prev

    21

  2 1 prev

    22

    23

rhg works on non-generaldelta revlogs:

    24

    25

  $ $NO_FALLBACK hg cat f -r .

    26

  1

    27

  2

    28

  3

    29

  4

    30

  5

    31

  6

    32

  7

    33

  8

    34

  9

    35

  10

    36

  11

    37

  12

    38

  13

    39

  14

    40

  15

    41

  16

    42

  17

    43

  18

    44

  19

    45

  20

    46

  footer