killdaemons: close pid file before killing processes With #serve enabled on Windows, I was getting occasional stacktraces like this: Errored test-hgweb-json.t: Traceback (most recent call last): File "./run-tests.py", line 724, in run self.tearDown() File "./run-tests.py", line 805, in tearDown killdaemons(entry) File "./run-tests.py", line 540, in killdaemons logfn=vlog) File "...\tests\killdaemons.py", line 94, in killdaemons os.unlink(pidfile) WindowsError: [Error 32] The process cannot access the file because it is being used by another process: '...\\hgtests.zmpqj3\\child80\\daemon.pids' Adrian suggested using util.posixfile, which works. However, the 'mercurial' package isn't in sys.path when invoking run-tests.py, and it isn't clear that hacking[1] it in is a good thing (especially for test-run-tests.t, which uses an installation in a temp folder). I tried using ProcessMonitor to figure out what the other process is, but that monitoring slows things down to such a degree that the issue doesn't occur. I was ready to blame the virus scanner, but it happens without that too. Looking at the code, I don't see anything that would have the pid file open. But I was able to get through about 20 full test runs without an issue with this minor change, whereas before it was pretty certain to hit this at least once in two or three runs. [1] https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-May/097907.html

     1

  $ hg init a

     2

  $ cd a

     3

  $ echo 123 > a

     4

  $ hg add a

     5

  $ hg commit -m "a" -u a

     6

     7

  $ cd ..

     8

  $ hg init b

     9

  $ cd b

    10

  $ echo 321 > b

    11

  $ hg add b

    12

  $ hg commit -m "b" -u b

    13

    14

  $ hg pull ../a

    15

  pulling from ../a

    16

  searching for changes

    17

  abort: repository is unrelated

    18

  [255]

    19

    20

  $ hg pull -f ../a

    21

  pulling from ../a

    22

  searching for changes

    23

  warning: repository is unrelated

    24

  requesting all changes

    25

  adding changesets

    26

  adding manifests

    27

  adding file changes

    28

  added 1 changesets with 1 changes to 1 files (+1 heads)

    29

  (run 'hg heads' to see heads, 'hg merge' to merge)

    30

    31

  $ hg heads

    32

  changeset:   1:9a79c33a9db3

    33

  tag:         tip

    34

  parent:      -1:000000000000

    35

  user:        a

    36

  date:        Thu Jan 01 00:00:00 1970 +0000

    37

  summary:     a

    38

    39

  changeset:   0:01f8062b2de5

    40

  user:        b

    41

  date:        Thu Jan 01 00:00:00 1970 +0000

    42

  summary:     b

    43

    44

    45

  $ cd ..