killdaemons: close pid file before killing processes With #serve enabled on Windows, I was getting occasional stacktraces like this: Errored test-hgweb-json.t: Traceback (most recent call last): File "./run-tests.py", line 724, in run self.tearDown() File "./run-tests.py", line 805, in tearDown killdaemons(entry) File "./run-tests.py", line 540, in killdaemons logfn=vlog) File "...\tests\killdaemons.py", line 94, in killdaemons os.unlink(pidfile) WindowsError: [Error 32] The process cannot access the file because it is being used by another process: '...\\hgtests.zmpqj3\\child80\\daemon.pids' Adrian suggested using util.posixfile, which works. However, the 'mercurial' package isn't in sys.path when invoking run-tests.py, and it isn't clear that hacking[1] it in is a good thing (especially for test-run-tests.t, which uses an installation in a temp folder). I tried using ProcessMonitor to figure out what the other process is, but that monitoring slows things down to such a degree that the issue doesn't occur. I was ready to blame the virus scanner, but it happens without that too. Looking at the code, I don't see anything that would have the pid file open. But I was able to get through about 20 full test runs without an issue with this minor change, whereas before it was pretty certain to hit this at least once in two or three runs. [1] https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-May/097907.html

     1

#require unix-permissions no-root

     2

     3

  $ hg init a

     4

  $ cd a

     5

  $ echo foo > b

     6

  $ hg add b

     7

  $ hg ci -m "b"

     8

     9

  $ chmod -w .hg/store

    10

    11

  $ cd ..

    12

    13

  $ hg clone a b

    14

  requesting all changes

    15

  adding changesets

    16

  adding manifests

    17

  adding file changes

    18

  added 1 changesets with 1 changes to 1 files

    19

  updating to branch default

    20

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    21

    22

  $ chmod +w a/.hg/store # let test clean up

    23

    24

  $ cd b

    25

  $ hg verify

    26

  checking changesets

    27

  checking manifests

    28

  crosschecking files in changesets and manifests

    29

  checking files

    30

  1 files, 1 changesets, 1 total revisions

    31

    32

  $ cd ..