killdaemons: close pid file before killing processes With #serve enabled on Windows, I was getting occasional stacktraces like this: Errored test-hgweb-json.t: Traceback (most recent call last): File "./run-tests.py", line 724, in run self.tearDown() File "./run-tests.py", line 805, in tearDown killdaemons(entry) File "./run-tests.py", line 540, in killdaemons logfn=vlog) File "...\tests\killdaemons.py", line 94, in killdaemons os.unlink(pidfile) WindowsError: [Error 32] The process cannot access the file because it is being used by another process: '...\\hgtests.zmpqj3\\child80\\daemon.pids' Adrian suggested using util.posixfile, which works. However, the 'mercurial' package isn't in sys.path when invoking run-tests.py, and it isn't clear that hacking[1] it in is a good thing (especially for test-run-tests.t, which uses an installation in a temp folder). I tried using ProcessMonitor to figure out what the other process is, but that monitoring slows things down to such a degree that the issue doesn't occur. I was ready to blame the virus scanner, but it happens without that too. Looking at the code, I don't see anything that would have the pid file open. But I was able to get through about 20 full test runs without an issue with this minor change, whereas before it was pretty certain to hit this at least once in two or three runs. [1] https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-May/097907.html

     1

Testing that hghave does not crash when checking features

     2

     3

  $ hghave --test-features 2>/dev/null

     4

     5

Testing hghave extensibility for third party tools

     6

     7

  $ cat > hghaveaddon.py <<EOF

     8

  > import hghave

     9

  > @hghave.check("custom", "custom hghave feature")

    10

  > def has_custom():

    11

  >     return True

    12

  > EOF

    13

    14

(invocation via run-tests.py)

    15

    16

  $ cat > test-hghaveaddon.t <<EOF

    17

  > #require custom

    18

  >   $ echo foo

    19

  >   foo

    20

  > EOF

    21

  $ run-tests.py $HGTEST_RUN_TESTS_PURE test-hghaveaddon.t

    22

  .

    23

  # Ran 1 tests, 0 skipped, 0 warned, 0 failed.

    24

    25

(invocation via command line)

    26

    27

  $ unset TESTDIR

    28

  $ hghave custom

    29

    30

(terminate with exit code 2 at failure of importing hghaveaddon.py)

    31

    32

  $ rm hghaveaddon.*

    33

  $ cat > hghaveaddon.py <<EOF

    34

  > importing this file should cause syntax error

    35

  > EOF

    36

    37

  $ hghave custom

    38

  failed to import hghaveaddon.py from '.': invalid syntax (hghaveaddon.py, line 1)

    39

  [2]