hgweb: code selection without line numbers in file source view All the source lines are put in a <pre> tag, which gives correct display and copy&paste in both Chromium (WebKit) and FireFox: line numbers are not copied, all the tabs and spaces are kept. This doesn't change the visual appearance of the view compared to current hgweb version and doesn't use any JS code. Also, stripes in this view are now generated clientside with CSS. This implementation is chosen because other variants have important issues: Strategy FF Chrome current D,LT,E,T,L D,L pre S,NW S,NW pre/div/nbsp LT,E,T,TS,NW TS,NW pre/div/br LT,E,T,NW NW ol/li/nbsp LT,E,T,TS,AJ TS,AJ ol/li/br LT,E,T,AJ AJ pre/span LV LV Legend Strategies: - current: implemented in hgweb before this patch, i.e. divs for each line, and line numbers links in the div too - pre: the whole code in one pre tag with newlines, all line numbers in another one with 'float: left' - pre/div/{nbsp,br}: same as just 'pre', but separate divs for each line and &nbsp; or <br> instead of empty lines (otherwise they are not copied at all) - ol/li/{nbsp,br}: a single ol with li's and divs for each line, &nbsp; or <br> same as in previous strategy - pre/span: this patch Problems: D = (very minor) display problems, like wrong width of leading tabs LT = loses leading/trailing whitespace E = loses embedded whitespace B = loses blank lines T = loses tabs L = selects line numbers LV = (only) visually selects line numbers LVE = (only) visually selects line numbers at empty lines S = no stripes (and no ability to easily highlight lines-which-are-linked-at in the future) TS = space copied instead of empty line AJ = get anchor links only with JS (they work even without) NW = no linewrap easily possible (in future) As for browser versions compatibility, the CSS tricks used are supported in (according to caniuse.com): a) line numbers generation with 'content:' property and CSS counters: IE 8+, all other popular browsers (in pre-WebKit Opera numbers are being copied) b) stripes ('nth-child' selector): IE 8+, FF 3.5+, Safari 3.2+, Opera 9.5+, all other popular browsers c) line numbers are not visually selected ('user-select:' property): IE 10+, Opera 15.0+, all other popular browsers This patch is based on a demo implementation by Martin Geisler <martin@geisler.net>.

     1

from mercurial import wireproto

     2

     3

class proto(object):

     4

    def __init__(self, args):

     5

        self.args = args

     6

    def getargs(self, spec):

     7

        args = self.args

     8

        args.setdefault('*', {})

     9

        names = spec.split()

    10

        return [args[n] for n in names]

    11

    12

class clientpeer(wireproto.wirepeer):

    13

    def __init__(self, serverrepo):

    14

        self.serverrepo = serverrepo

    15

    def _call(self, cmd, **args):

    16

        return wireproto.dispatch(self.serverrepo, proto(args), cmd)

    17

    18

    @wireproto.batchable

    19

    def greet(self, name):

    20

        f = wireproto.future()

    21

        yield wireproto.todict(name=mangle(name)), f

    22

        yield unmangle(f.value)

    23

    24

class serverrepo(object):

    25

    def greet(self, name):

    26

        return "Hello, " + name

    27

    28

    def filtered(self, name):

    29

        return self

    30

    31

def mangle(s):

    32

    return ''.join(chr(ord(c) + 1) for c in s)

    33

def unmangle(s):

    34

    return ''.join(chr(ord(c) - 1) for c in s)

    35

    36

def greet(repo, proto, name):

    37

    return mangle(repo.greet(unmangle(name)))

    38

    39

wireproto.commands['greet'] = (greet, 'name',)

    40

    41

srv = serverrepo()

    42

clt = clientpeer(srv)

    43

    44

print clt.greet("Foobar")

    45

b = clt.batch()

    46

fs = [b.greet(s) for s in ["Fo, =;o", "Bar"]]

    47

b.submit()

    48

print [f.value for f in fs]