templatekw: compare target context and its parent exactly (issue4690) Before this patch, template keywords `{file_mods}`, `{file_adds}` and `{file_dels}` use values gotten by `repo.status(ctx.p1().node(), ctx.node())`. But this doesn't work as expected if `ctx` is `memctx` or `workingcommitctx`. Typical case of templating with these contexts is customization of the text shown in the commit message editor by `[committemplate]` configuration. In this case, `ctx.node()` returns None and it causes comparison between `ctx.p1()` and `workingctx`. `workingctx` lists up all changed files in the working directory even at selective committing. BTW, `{files}` uses `ctx.files()` and it works as expected. To compare target context and its parent exactly, this patch passes `ctx.p1()` and `ctx` without `node()`-nize. This avoids unexpected comparison with `workingctx`. This patch uses a little redundant template configurations in `test-commit.t`, but they are needed to avoid regression around problems fixed by a4958cdb2202 and 1e6fb8db666e: accessing on `ctx` may break `ctx._status` field.

     1

#require execbit

     2

     3

  $ hg init repo

     4

  $ cd repo

     5

  $ echo foo > foo

     6

  $ chmod 644 foo

     7

  $ hg ci -qAm '644'

     8

     9

  $ chmod 755 foo

    10

  $ hg ci -qAm '755'

    11

    12

reverting to rev 0

    13

    14

  $ hg revert -a -r 0

    15

  reverting foo

    16

  $ hg st

    17

  M foo

    18

  $ hg diff --git

    19

  diff --git a/foo b/foo

    20

  old mode 100755

    21

  new mode 100644

    22

    23

  $ cd ..