url: refactor util.drop_scheme() and hg.localpath() into url.localpath() This replaces util.drop_scheme() with url.localpath(), using url.url for parsing instead of doing it on its own. The function is moved from util to url to avoid an import cycle. hg.localpath() is removed in favor of using url.localpath(). This provides more consistent behavior between "hg clone" and other commands. To preserve backwards compatibility, URLs like bundle://../foo still refer to ../foo, not /foo. If a URL contains a scheme, percent-encoded entities are decoded. When there's no scheme, all characters are left untouched. Comparison of old and new behaviors: URL drop_scheme() hg.localpath() url.localpath() === ============= ============== =============== file://foo/foo /foo foo/foo /foo file://localhost:80/foo /foo localhost:80/foo /foo file://localhost:/foo /foo localhost:/foo /foo file://localhost/foo /foo /foo /foo file:///foo /foo /foo /foo file://foo (empty string) foo / file:/foo /foo /foo /foo file:foo foo foo foo file:foo%23bar foo%23bar foo%23bar foo#bar foo%23bar foo%23bar foo%23bar foo%23bar /foo /foo /foo /foo Windows-related paths on Windows: URL drop_scheme() hg.localpath() url.localpath() === ============= ============== =============== file:///C:/foo C:/C:/foo /C:/foo C:/foo file:///D:/foo C:/D:/foo /D:/foo D:/foo file://C:/foo C:/foo C:/foo C:/foo file://D:/foo C:/foo D:/foo D:/foo file:////foo/bar //foo/bar //foo/bar //foo/bar //foo/bar //foo/bar //foo/bar //foo/bar \\foo\bar //foo/bar //foo/bar \\foo\bar Windows-related paths on other platforms: file:///C:/foo C:/C:/foo /C:/foo C:/foo file:///D:/foo C:/D:/foo /D:/foo D:/foo file://C:/foo C:/foo C:/foo C:/foo file://D:/foo C:/foo D:/foo D:/foo file:////foo/bar //foo/bar //foo/bar //foo/bar //foo/bar //foo/bar //foo/bar //foo/bar \\foo\bar //foo/bar //foo/bar \\foo\bar For more information about file:// URL handling, see: http://www-archive.mozilla.org/quality/networking/testing/filetests.html Related issues: - issue1153: File URIs aren't handled correctly in windows This patch should preserve the fix implemented in 2770d03ae49f. However, it goes a step further and "promotes" Windows-style drive letters from being interpreted as host names to being part of the path. - issue2154: Cannot escape '#' in Mercurial URLs (#1172 in THG) The fragment is still interpreted as a revision or a branch, even in paths to bundles. However, when file: is used, percent-encoded entities are decoded, so file:test%23bundle.hg can refer to test#bundle.hg ond isk.

     1

  $ hg init a

     2

  $ cd a

     3

     4

  $ hg diff inexistent1 inexistent2

     5

  inexistent1: No such file or directory

     6

  inexistent2: No such file or directory

     7

     8

  $ echo bar > foo

     9

  $ hg add foo

    10

  $ hg ci -m 'add foo'

    11

    12

  $ echo foobar > foo

    13

  $ hg ci -m 'change foo'

    14

    15

  $ hg --quiet diff -r 0 -r 1

    16

  --- a/foo	Thu Jan 01 00:00:00 1970 +0000

    17

  +++ b/foo	Thu Jan 01 00:00:00 1970 +0000

    18

  @@ -1,1 +1,1 @@

    19

  -bar

    20

  +foobar

    21

    22

  $ hg diff -r 0 -r 1

    23

  diff -r a99fb63adac3 -r 9b8568d3af2f foo

    24

  --- a/foo	Thu Jan 01 00:00:00 1970 +0000

    25

  +++ b/foo	Thu Jan 01 00:00:00 1970 +0000

    26

  @@ -1,1 +1,1 @@

    27

  -bar

    28

  +foobar

    29

    30

  $ hg --verbose diff -r 0 -r 1

    31

  diff -r a99fb63adac3 -r 9b8568d3af2f foo

    32

  --- a/foo	Thu Jan 01 00:00:00 1970 +0000

    33

  +++ b/foo	Thu Jan 01 00:00:00 1970 +0000

    34

  @@ -1,1 +1,1 @@

    35

  -bar

    36

  +foobar

    37

    38

  $ hg --debug diff -r 0 -r 1

    39

  diff -r a99fb63adac3f31816a22f665bc3b7a7655b30f4 -r 9b8568d3af2f1749445eef03aede868a6f39f210 foo

    40

  --- a/foo	Thu Jan 01 00:00:00 1970 +0000

    41

  +++ b/foo	Thu Jan 01 00:00:00 1970 +0000

    42

  @@ -1,1 +1,1 @@

    43

  -bar

    44

  +foobar

    45