outgoing: rework the handling of the `missingroots` case to be faster The previous implementation was slow, to the point it was taking a significant amount of `hg bundle --type none-streamv2` call. We rework the code to compute the same value much faster, making the operation disappear from the `hg bundle --type none-streamv2` profile. Someone would remark that producing a streamclone does not requires an `outgoing` object. However that is a matter for another day. There is other user of `missingroots` (non stream `hg bundle` call for example), and they will also benefit from this rework. We implement an old TODO in the process, directly computing the missing and common attribute as we have most element at hand already. ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 7.750458 after: 6.665565 (-14.00%, -1.08) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 0.700229 after: 0.496050 (-29.16%, -0.20) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 346.508952 after: 316.749699 (-8.59%, -29.76) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 3.401700 after: 2.915810 (-14.28%, -0.49) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 1.870798 after: 1.461583 (-21.87%, -0.41) note: this whole `missingroots` of outgoing has a limited number of callers and could likely be replace by something simpler (like taking an explicit "missing_revs" set for example). However this is a wider change and we focus on a small impact, quick rework that does not change the API for now.

     1

#testcases dirstate-v1 dirstate-v2

     2

     3

#if dirstate-v2

     4

  $ cat >> $HGRCPATH << EOF

     5

  > [format]

     6

  > use-dirstate-v2=1

     7

  > [storage]

     8

  > dirstate-v2.slow-path=allow

     9

  > EOF

    10

#endif

    11

    12

  $ rm -rf r

    13

    14

  $ hg init r

    15

  $ cd r

    16

  $ mkdir d1

    17

  $ mkdir d2

    18

  $ touch d1/f d2/f

    19

  $ hg commit -Am '.'

    20

  adding d1/f

    21

  adding d2/f

    22

  $ echo 'syntax:re' >> .hgignore

    23

  $ echo '^d1$' >> .hgignore

    24

  $ hg commit -Am "ignore d1"

    25

  adding .hgignore

    26

    27

Now d1 is a directory that's both committed and ignored.

    28

Untracked files in d2 are still shown, but ones in d1 are ignored:

    29

    30

  $ touch d1/g

    31

  $ touch d2/g

    32

  $ RAYON_NUM_THREADS=1 hg status

    33

  ? d2/g