outgoing: rework the handling of the `missingroots` case to be faster The previous implementation was slow, to the point it was taking a significant amount of `hg bundle --type none-streamv2` call. We rework the code to compute the same value much faster, making the operation disappear from the `hg bundle --type none-streamv2` profile. Someone would remark that producing a streamclone does not requires an `outgoing` object. However that is a matter for another day. There is other user of `missingroots` (non stream `hg bundle` call for example), and they will also benefit from this rework. We implement an old TODO in the process, directly computing the missing and common attribute as we have most element at hand already. ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 7.750458 after: 6.665565 (-14.00%, -1.08) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 0.700229 after: 0.496050 (-29.16%, -0.20) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 346.508952 after: 316.749699 (-8.59%, -29.76) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 3.401700 after: 2.915810 (-14.28%, -0.49) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 1.870798 after: 1.461583 (-21.87%, -0.41) note: this whole `missingroots` of outgoing has a limited number of callers and could likely be replace by something simpler (like taking an explicit "missing_revs" set for example). However this is a wider change and we focus on a small impact, quick rework that does not change the API for now.

     1

#require no-windows

     2

     3

  $ . "$TESTDIR/remotefilelog-library.sh"

     4

     5

  $ hg init master

     6

  $ cd master

     7

  $ cat >> .hg/hgrc <<EOF

     8

  > [remotefilelog]

     9

  > server=True

    10

  > EOF

    11

  $ echo x > x

    12

  $ hg commit -qAm x

    13

    14

  $ cd ..

    15

    16

  $ hgcloneshallow ssh://user@dummy/master shallow -q

    17

  1 files fetched over 1 fetches - (1 misses, 0.00% hit ratio) over *s (glob)

    18

    19

  $ cd master

    20

  $ echo xx > x

    21

  $ hg commit -qAm x2

    22

  $ cd ..

    23

    24

# Test cache misses with read only permissions on server

    25

    26

  $ chmod -R a-w master/.hg/remotefilelogcache

    27

  $ cd shallow

    28

  $ hg pull -q

    29

  $ hg update

    30

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    31

  1 files fetched over 1 fetches - (1 misses, 0.00% hit ratio) over *s (glob)

    32

  $ cd ..

    33

    34

  $ chmod -R u+w master/.hg/remotefilelogcache

    35

    36

#if suidbit

    37

    38

# Test setting up shared cache with the right permissions

    39

# (this is hard to test in a cross platform way, so we just make sure nothing

    40

# crashes)

    41

    42

  $ rm -rf $CACHEDIR

    43

  $ umask 002

    44

  $ mkdir $CACHEDIR

    45

  $ hg -q clone --shallow ssh://user@dummy/master shallow2 --config remotefilelog.cachegroup="`id -g -n`"

    46

  1 files fetched over 1 fetches - (1 misses, 0.00% hit ratio) over * (glob)

    47

  $ ls -ld $CACHEDIR/11

    48

  drwxrws* $TESTTMP/hgcache/11 (glob)

    49

    50

#endif