outgoing: rework the handling of the `missingroots` case to be faster The previous implementation was slow, to the point it was taking a significant amount of `hg bundle --type none-streamv2` call. We rework the code to compute the same value much faster, making the operation disappear from the `hg bundle --type none-streamv2` profile. Someone would remark that producing a streamclone does not requires an `outgoing` object. However that is a matter for another day. There is other user of `missingroots` (non stream `hg bundle` call for example), and they will also benefit from this rework. We implement an old TODO in the process, directly computing the missing and common attribute as we have most element at hand already. ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 7.750458 after: 6.665565 (-14.00%, -1.08) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 0.700229 after: 0.496050 (-29.16%, -0.20) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 346.508952 after: 316.749699 (-8.59%, -29.76) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 3.401700 after: 2.915810 (-14.28%, -0.49) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 1.870798 after: 1.461583 (-21.87%, -0.41) note: this whole `missingroots` of outgoing has a limited number of callers and could likely be replace by something simpler (like taking an explicit "missing_revs" set for example). However this is a wider change and we focus on a small impact, quick rework that does not change the API for now.

     1

  $ . "$TESTDIR/narrow-library.sh"

     2

  $ hg init master

     3

  $ cd master

     4

  $ echo treemanifest >> .hg/requires

     5

  $ echo 'contents of file' > file

     6

  $ mkdir foo

     7

  $ echo 'contents of foo/bar' > foo/bar

     8

  $ hg ci -Am 'some change'

     9

  adding file

    10

  adding foo/bar

    11

    12

  $ cd ..

    13

  $ hg clone --narrow ssh://user@dummy/master copy --include=foo

    14

  requesting all changes

    15

  adding changesets

    16

  adding manifests

    17

  adding file changes

    18

  added 1 changesets with 1 changes to 1 files

    19

  new changesets * (glob)

    20

  updating to branch default

    21

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    22

  $ cd copy

    23

    24

  $ hg debugdirstate --no-dates

    25

  n *         20 *               foo/bar (glob)

    26

  $ mv .hg/dirstate .hg/old_dirstate

    27

  $ dd bs=40 count=1 if=.hg/old_dirstate of=.hg/dirstate 2>/dev/null

    28

  $ hg debugdirstate

    29

  $ hg debugrebuilddirstate

    30

  $ hg debugdirstate

    31

  n *         * unset               foo/bar (glob)