outgoing: rework the handling of the `missingroots` case to be faster The previous implementation was slow, to the point it was taking a significant amount of `hg bundle --type none-streamv2` call. We rework the code to compute the same value much faster, making the operation disappear from the `hg bundle --type none-streamv2` profile. Someone would remark that producing a streamclone does not requires an `outgoing` object. However that is a matter for another day. There is other user of `missingroots` (non stream `hg bundle` call for example), and they will also benefit from this rework. We implement an old TODO in the process, directly computing the missing and common attribute as we have most element at hand already. ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 7.750458 after: 6.665565 (-14.00%, -1.08) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 0.700229 after: 0.496050 (-29.16%, -0.20) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 346.508952 after: 316.749699 (-8.59%, -29.76) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 3.401700 after: 2.915810 (-14.28%, -0.49) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 1.870798 after: 1.461583 (-21.87%, -0.41) note: this whole `missingroots` of outgoing has a limited number of callers and could likely be replace by something simpler (like taking an explicit "missing_revs" set for example). However this is a wider change and we focus on a small impact, quick rework that does not change the API for now.

     1

     2

  $ cat > unix2mac.py <<EOF

     3

  > import sys

     4

  > 

     5

  > for path in sys.argv[1:]:

     6

  >     data = open(path, 'rb').read()

     7

  >     data = data.replace(b'\n', b'\r')

     8

  >     open(path, 'wb').write(data)

     9

  > EOF

    10

  $ hg init

    11

  $ echo '[hooks]' >> .hg/hgrc

    12

  $ echo 'pretxncommit.cr = python:hgext.win32text.forbidcr' >> .hg/hgrc

    13

  $ echo 'pretxnchangegroup.cr = python:hgext.win32text.forbidcr' >> .hg/hgrc

    14

  $ cat .hg/hgrc

    15

  [hooks]

    16

  pretxncommit.cr = python:hgext.win32text.forbidcr

    17

  pretxnchangegroup.cr = python:hgext.win32text.forbidcr

    18

    19

  $ echo hello > f

    20

  $ hg add f

    21

  $ hg ci -m 1

    22

    23

  $ "$PYTHON" unix2mac.py f

    24

  $ hg ci -m 2

    25

  attempt to commit or push text file(s) using CR line endings

    26

  in dea860dc51ec: f

    27

  transaction abort!

    28

  rollback completed

    29

  abort: pretxncommit.cr hook failed

    30

  [40]

    31

  $ hg cat f | f --hexdump

    32

    33

  0000: 68 65 6c 6c 6f 0a                               |hello.|

    34

  $ f --hexdump f

    35

  f:

    36

  0000: 68 65 6c 6c 6f 0d                               |hello.|