outgoing: rework the handling of the `missingroots` case to be faster The previous implementation was slow, to the point it was taking a significant amount of `hg bundle --type none-streamv2` call. We rework the code to compute the same value much faster, making the operation disappear from the `hg bundle --type none-streamv2` profile. Someone would remark that producing a streamclone does not requires an `outgoing` object. However that is a matter for another day. There is other user of `missingroots` (non stream `hg bundle` call for example), and they will also benefit from this rework. We implement an old TODO in the process, directly computing the missing and common attribute as we have most element at hand already. ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 7.750458 after: 6.665565 (-14.00%, -1.08) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 0.700229 after: 0.496050 (-29.16%, -0.20) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 346.508952 after: 316.749699 (-8.59%, -29.76) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 3.401700 after: 2.915810 (-14.28%, -0.49) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 1.870798 after: 1.461583 (-21.87%, -0.41) note: this whole `missingroots` of outgoing has a limited number of callers and could likely be replace by something simpler (like taking an explicit "missing_revs" set for example). However this is a wider change and we focus on a small impact, quick rework that does not change the API for now.

     1

# Import something from Mercurial, so the module loader gets initialized.

     2

from mercurial import pycompat

     3

     4

del pycompat  # unused for now

     5

     6

from hgext.lfs import pointer

     7

     8

     9

def tryparse(text):

    10

    r = {}

    11

    try:

    12

        r = pointer.deserialize(text)

    13

        print('ok')

    14

    except Exception as ex:

    15

        print((b'%s' % ex).decode('ascii'))

    16

    if r:

    17

        text2 = r.serialize()

    18

        if text2 != text:

    19

            print('reconstructed text differs')

    20

    return r

    21

    22

    23

t = (

    24

    b'version https://git-lfs.github.com/spec/v1\n'

    25

    b'oid sha256:4d7a214614ab2935c943f9e0ff69d22eadbb8f32b1'

    26

    b'258daaa5e2ca24d17e2393\n'

    27

    b'size 12345\n'

    28

    b'x-foo extra-information\n'

    29

)

    30

    31

tryparse(b'')

    32

tryparse(t)

    33

tryparse(t.replace(b'git-lfs', b'unknown'))

    34

tryparse(t.replace(b'v1\n', b'v1\n\n'))

    35

tryparse(t.replace(b'sha256', b'ahs256'))

    36

tryparse(t.replace(b'sha256:', b''))

    37

tryparse(t.replace(b'12345', b'0x12345'))

    38

tryparse(t.replace(b'extra-information', b'extra\0information'))

    39

tryparse(t.replace(b'extra-information', b'extra\ninformation'))

    40

tryparse(t.replace(b'x-foo', b'x_foo'))

    41

tryparse(t.replace(b'oid', b'blobid'))

    42

tryparse(t.replace(b'size', b'size-bytes').replace(b'oid', b'object-id'))