outgoing: rework the handling of the `missingroots` case to be faster The previous implementation was slow, to the point it was taking a significant amount of `hg bundle --type none-streamv2` call. We rework the code to compute the same value much faster, making the operation disappear from the `hg bundle --type none-streamv2` profile. Someone would remark that producing a streamclone does not requires an `outgoing` object. However that is a matter for another day. There is other user of `missingroots` (non stream `hg bundle` call for example), and they will also benefit from this rework. We implement an old TODO in the process, directly computing the missing and common attribute as we have most element at hand already. ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 7.750458 after: 6.665565 (-14.00%, -1.08) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 0.700229 after: 0.496050 (-29.16%, -0.20) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 346.508952 after: 316.749699 (-8.59%, -29.76) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 3.401700 after: 2.915810 (-14.28%, -0.49) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 1.870798 after: 1.461583 (-21.87%, -0.41) note: this whole `missingroots` of outgoing has a limited number of callers and could likely be replace by something simpler (like taking an explicit "missing_revs" set for example). However this is a wider change and we focus on a small impact, quick rework that does not change the API for now.

     1

import os

     2

from mercurial.hgweb import hgwebdir_mod

     3

     4

hgwebdir = hgwebdir_mod.hgwebdir

     5

     6

os.mkdir(b'webdir')

     7

os.chdir(b'webdir')

     8

     9

webdir = os.path.realpath(b'.')

    10

    11

    12

def trivial_response(req, res):

    13

    return []

    14

    15

    16

def make_hgwebdir(gc_rate=None):

    17

    config = os.path.join(webdir, b'hgwebdir.conf')

    18

    with open(config, 'wb') as configfile:

    19

        configfile.write(b'[experimental]\n')

    20

        if gc_rate is not None:

    21

            configfile.write(b'web.full-garbage-collection-rate=%d\n' % gc_rate)

    22

    hg_wd = hgwebdir(config)

    23

    hg_wd._runwsgi = trivial_response

    24

    return hg_wd

    25

    26

    27

def process_requests(webdir_instance, number):

    28

    # we don't care for now about passing realistic arguments

    29

    for _ in range(number):

    30

        for chunk in webdir_instance.run_wsgi(None, None):

    31

            pass

    32

    33

    34

without_gc = make_hgwebdir(gc_rate=0)

    35

process_requests(without_gc, 5)

    36

assert without_gc.requests_count == 5

    37

assert without_gc.gc_full_collections_done == 0

    38

    39

with_gc = make_hgwebdir(gc_rate=2)

    40

process_requests(with_gc, 5)

    41

assert with_gc.requests_count == 5

    42

assert with_gc.gc_full_collections_done == 2

    43

    44

with_systematic_gc = make_hgwebdir()  # default value of the setting

    45

process_requests(with_systematic_gc, 3)

    46

assert with_systematic_gc.requests_count == 3

    47

assert with_systematic_gc.gc_full_collections_done == 3