outgoing: rework the handling of the `missingroots` case to be faster The previous implementation was slow, to the point it was taking a significant amount of `hg bundle --type none-streamv2` call. We rework the code to compute the same value much faster, making the operation disappear from the `hg bundle --type none-streamv2` profile. Someone would remark that producing a streamclone does not requires an `outgoing` object. However that is a matter for another day. There is other user of `missingroots` (non stream `hg bundle` call for example), and they will also benefit from this rework. We implement an old TODO in the process, directly computing the missing and common attribute as we have most element at hand already. ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 7.750458 after: 6.665565 (-14.00%, -1.08) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 0.700229 after: 0.496050 (-29.16%, -0.20) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 346.508952 after: 316.749699 (-8.59%, -29.76) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 3.401700 after: 2.915810 (-14.28%, -0.49) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 1.870798 after: 1.461583 (-21.87%, -0.41) note: this whole `missingroots` of outgoing has a limited number of callers and could likely be replace by something simpler (like taking an explicit "missing_revs" set for example). However this is a wider change and we focus on a small impact, quick rework that does not change the API for now.

     1

#require test-repo slow docker

     2

     3

  $ . "$TESTDIR/helpers-testrepo.sh"

     4

  $ testrepohgenv

     5

     6

Ensure debuild doesn't run the testsuite, as that could get silly.

     7

  $ DEB_BUILD_OPTIONS=nocheck

     8

  $ export DEB_BUILD_OPTIONS

     9

  $ OUTPUTDIR=`pwd`

    10

  $ export OUTPUTDIR

    11

    12

  $ cd "$TESTDIR"/..

    13

  $ make docker-debian-buster > $OUTPUTDIR/build.log 2>&1

    14

  $ cd $OUTPUTDIR

    15

  $ ls *.deb

    16

  mercurial-common_*.deb (glob)

    17

  mercurial_*.deb (glob)

    18

    19

We check debian package contents with portable tools so that when

    20

we're on non-debian machines we can still test the packages that are

    21

built using docker.

    22

    23

main deb should have .so but no .py

    24

  $ ar x mercurial_*.deb

    25

  $ tar tf data.tar* | grep -E '(localrepo|parsers)'

    26

  ./usr/lib/python2.7/dist-packages/mercurial/parsers*.so (glob)

    27

mercurial-common should have .py but no .so or .pyc

    28

  $ ar x mercurial-common_*.deb

    29

  $ tar tf data.tar* | grep -E '(localrepo|parsers)'

    30

  ./usr/lib/python2.7/dist-packages/mercurial/pure/parsers.py

    31

  ./usr/lib/python2.7/dist-packages/mercurial/localrepo.py