outgoing: rework the handling of the `missingroots` case to be faster The previous implementation was slow, to the point it was taking a significant amount of `hg bundle --type none-streamv2` call. We rework the code to compute the same value much faster, making the operation disappear from the `hg bundle --type none-streamv2` profile. Someone would remark that producing a streamclone does not requires an `outgoing` object. However that is a matter for another day. There is other user of `missingroots` (non stream `hg bundle` call for example), and they will also benefit from this rework. We implement an old TODO in the process, directly computing the missing and common attribute as we have most element at hand already. ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 7.750458 after: 6.665565 (-14.00%, -1.08) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 0.700229 after: 0.496050 (-29.16%, -0.20) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 346.508952 after: 316.749699 (-8.59%, -29.76) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 3.401700 after: 2.915810 (-14.28%, -0.49) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 1.870798 after: 1.461583 (-21.87%, -0.41) note: this whole `missingroots` of outgoing has a limited number of callers and could likely be replace by something simpler (like taking an explicit "missing_revs" set for example). However this is a wider change and we focus on a small impact, quick rework that does not change the API for now.

     1

#require rust

     2

     3

  $ cat >> $HGRCPATH << EOF

     4

  > [format]

     5

  > use-dirstate-v2=1

     6

  > [storage]

     7

  > dirstate-v2.slow-path=allow

     8

  > EOF

     9

    10

  $ hg init t

    11

  $ cd t

    12

    13

  $ for i in 1 2 3 4 5 6 7 8 9 10; do touch foobar$i; done

    14

  $ hg add .

    15

  adding foobar1

    16

  adding foobar10

    17

  adding foobar2

    18

  adding foobar3

    19

  adding foobar4

    20

  adding foobar5

    21

  adding foobar6

    22

  adding foobar7

    23

  adding foobar8

    24

  adding foobar9

    25

  $ hg commit -m "1"

    26

    27

Check that there's no space leak on debugrebuilddirstate

    28

    29

  $ f --size .hg/dirstate*

    30

  .hg/dirstate: size=133

    31

  .hg/dirstate.88698448: size=511

    32

  $ hg debugrebuilddirstate

    33

  $ f --size .hg/dirstate*

    34

  .hg/dirstate: size=133

    35

  .hg/dirstate.6b8ab34b: size=511

    36

  $ hg debugrebuilddirstate

    37

  $ f --size .hg/dirstate*

    38

  .hg/dirstate: size=133

    39

  .hg/dirstate.b875dfc5: size=511