mercurial: tests/list-tree.py@e3a5ec2d236a (annotated)

outgoing: rework the handling of the `missingroots` case to be faster The previous implementation was slow, to the point it was taking a significant amount of `hg bundle --type none-streamv2` call. We rework the code to compute the same value much faster, making the operation disappear from the `hg bundle --type none-streamv2` profile. Someone would remark that producing a streamclone does not requires an `outgoing` object. However that is a matter for another day. There is other user of `missingroots` (non stream `hg bundle` call for example), and they will also benefit from this rework. We implement an old TODO in the process, directly computing the missing and common attribute as we have most element at hand already. ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 7.750458 after: 6.665565 (-14.00%, -1.08) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 0.700229 after: 0.496050 (-29.16%, -0.20) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 346.508952 after: 316.749699 (-8.59%, -29.76) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 3.401700 after: 2.915810 (-14.28%, -0.49) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 1.870798 after: 1.461583 (-21.87%, -0.41) note: this whole `missingroots` of outgoing has a limited number of callers and could likely be replace by something simpler (like taking an explicit "missing_revs" set for example). However this is a wider change and we focus on a small impact, quick rework that does not change the API for now.

35217 aa905f9cdcda tests: write and use a custom helper script to avoid find's -printf Augie Fackler <augie@google.com> parents: diff changeset	1	import argparse
aa905f9cdcda tests: write and use a custom helper script to avoid find's -printf Augie Fackler <augie@google.com> parents: diff changeset	2	import os
aa905f9cdcda tests: write and use a custom helper script to avoid find's -printf Augie Fackler <augie@google.com> parents: diff changeset	3
aa905f9cdcda tests: write and use a custom helper script to avoid find's -printf Augie Fackler <augie@google.com> parents: diff changeset	4	ap = argparse.ArgumentParser()
aa905f9cdcda tests: write and use a custom helper script to avoid find's -printf Augie Fackler <augie@google.com> parents: diff changeset	5	ap.add_argument('path', nargs='+')
aa905f9cdcda tests: write and use a custom helper script to avoid find's -printf Augie Fackler <augie@google.com> parents: diff changeset	6	opts = ap.parse_args()
aa905f9cdcda tests: write and use a custom helper script to avoid find's -printf Augie Fackler <augie@google.com> parents: diff changeset	7
43076 2372284d9457 formatting: blacken the codebase Augie Fackler <augie@google.com> parents: 35380 diff changeset	8
35217 aa905f9cdcda tests: write and use a custom helper script to avoid find's -printf Augie Fackler <augie@google.com> parents: diff changeset	9	def gather():
aa905f9cdcda tests: write and use a custom helper script to avoid find's -printf Augie Fackler <augie@google.com> parents: diff changeset	10	for p in opts.path:
aa905f9cdcda tests: write and use a custom helper script to avoid find's -printf Augie Fackler <augie@google.com> parents: diff changeset	11	if not os.path.exists(p):
aa905f9cdcda tests: write and use a custom helper script to avoid find's -printf Augie Fackler <augie@google.com> parents: diff changeset	12	return
aa905f9cdcda tests: write and use a custom helper script to avoid find's -printf Augie Fackler <augie@google.com> parents: diff changeset	13	if os.path.isdir(p):
aa905f9cdcda tests: write and use a custom helper script to avoid find's -printf Augie Fackler <augie@google.com> parents: diff changeset	14	yield p + os.path.sep
aa905f9cdcda tests: write and use a custom helper script to avoid find's -printf Augie Fackler <augie@google.com> parents: diff changeset	15	for dirpath, dirs, files in os.walk(p):
aa905f9cdcda tests: write and use a custom helper script to avoid find's -printf Augie Fackler <augie@google.com> parents: diff changeset	16	for d in dirs:
aa905f9cdcda tests: write and use a custom helper script to avoid find's -printf Augie Fackler <augie@google.com> parents: diff changeset	17	yield os.path.join(dirpath, d) + os.path.sep
aa905f9cdcda tests: write and use a custom helper script to avoid find's -printf Augie Fackler <augie@google.com> parents: diff changeset	18	for f in files:
aa905f9cdcda tests: write and use a custom helper script to avoid find's -printf Augie Fackler <augie@google.com> parents: diff changeset	19	yield os.path.join(dirpath, f)
aa905f9cdcda tests: write and use a custom helper script to avoid find's -printf Augie Fackler <augie@google.com> parents: diff changeset	20	else:
aa905f9cdcda tests: write and use a custom helper script to avoid find's -printf Augie Fackler <augie@google.com> parents: diff changeset	21	yield p
aa905f9cdcda tests: write and use a custom helper script to avoid find's -printf Augie Fackler <augie@google.com> parents: diff changeset	22
43076 2372284d9457 formatting: blacken the codebase Augie Fackler <augie@google.com> parents: 35380 diff changeset	23
35380 acff41957b34 tests: stabilize the sorted output of list-tree.py on Windows Matt Harbison <matt_harbison@yahoo.com> parents: 35217 diff changeset	24	print('\n'.join(sorted(gather(), key=lambda x: x.replace(os.path.sep, '/'))))

author	Pierre-Yves David <pierre-yves.david@octobus.net>
	Tue, 09 Apr 2024 22:36:35 +0200
changeset 51594	e3a5ec2d236a
parent 48875	6000f5b25c9b
permissions	-rw-r--r--