outgoing: rework the handling of the `missingroots` case to be faster The previous implementation was slow, to the point it was taking a significant amount of `hg bundle --type none-streamv2` call. We rework the code to compute the same value much faster, making the operation disappear from the `hg bundle --type none-streamv2` profile. Someone would remark that producing a streamclone does not requires an `outgoing` object. However that is a matter for another day. There is other user of `missingroots` (non stream `hg bundle` call for example), and they will also benefit from this rework. We implement an old TODO in the process, directly computing the missing and common attribute as we have most element at hand already. ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 7.750458 after: 6.665565 (-14.00%, -1.08) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 0.700229 after: 0.496050 (-29.16%, -0.20) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 346.508952 after: 316.749699 (-8.59%, -29.76) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 3.401700 after: 2.915810 (-14.28%, -0.49) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 1.870798 after: 1.461583 (-21.87%, -0.41) note: this whole `missingroots` of outgoing has a limited number of callers and could likely be replace by something simpler (like taking an explicit "missing_revs" set for example). However this is a wider change and we focus on a small impact, quick rework that does not change the API for now.

     1

#!/usr/bin/env python3

     2

     3

     4

import os

     5

import shlex

     6

import subprocess

     7

import sys

     8

     9

os.chdir(os.getenv('TESTTMP'))

    10

    11

if sys.argv[1] != "user@dummy":

    12

    sys.exit(-1)

    13

    14

os.environ["SSH_CLIENT"] = "%s 1 2" % os.environ.get('LOCALIP', '127.0.0.1')

    15

    16

log = open("dummylog", "ab")

    17

log.write(b"Got arguments")

    18

for i, arg in enumerate(sys.argv[1:]):

    19

    log.write(b" %d:%s" % (i + 1, arg.encode('latin1')))

    20

log.write(b"\n")

    21

log.close()

    22

hgcmd = sys.argv[2]

    23

if os.name == 'nt':

    24

    # hack to make simple unix single quote quoting work on windows

    25

    hgcmd = hgcmd.replace("'", '"')

    26

    cmds = shlex.split(hgcmd)

    27

    if cmds[0].endswith('.py'):

    28

        python_exe = os.environ['PYTHON']

    29

        cmds.insert(0, python_exe)

    30

    hgcmd = shlex.join(cmds)

    31

    # shlex generate windows incompatible string...

    32

    hgcmd = hgcmd.replace("'", '"')

    33

r = subprocess.call(hgcmd, shell=True, close_fds=True)

    34

sys.exit(bool(r))