outgoing: rework the handling of the `missingroots` case to be faster The previous implementation was slow, to the point it was taking a significant amount of `hg bundle --type none-streamv2` call. We rework the code to compute the same value much faster, making the operation disappear from the `hg bundle --type none-streamv2` profile. Someone would remark that producing a streamclone does not requires an `outgoing` object. However that is a matter for another day. There is other user of `missingroots` (non stream `hg bundle` call for example), and they will also benefit from this rework. We implement an old TODO in the process, directly computing the missing and common attribute as we have most element at hand already. ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 7.750458 after: 6.665565 (-14.00%, -1.08) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 0.700229 after: 0.496050 (-29.16%, -0.20) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 346.508952 after: 316.749699 (-8.59%, -29.76) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 3.401700 after: 2.915810 (-14.28%, -0.49) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 1.870798 after: 1.461583 (-21.87%, -0.41) note: this whole `missingroots` of outgoing has a limited number of callers and could likely be replace by something simpler (like taking an explicit "missing_revs" set for example). However this is a wider change and we focus on a small impact, quick rework that does not change the API for now.

     1

import sys

     2

import unittest

     3

     4

if sys.version_info[0] < 3:

     5

    base_class = unittest._TextTestResult

     6

else:

     7

    base_class = unittest.TextTestResult

     8

     9

    10

class TestResult(base_class):

    11

    def __init__(self, options, *args, **kwargs):

    12

        super(TestResult, self).__init__(*args, **kwargs)

    13

        self._options = options

    14

    15

        # unittest.TestResult didn't have skipped until 2.7. We need to

    16

        # polyfill it.

    17

        self.skipped = []

    18

    19

        # We have a custom "ignored" result that isn't present in any Python

    20

        # unittest implementation. It is very similar to skipped. It may make

    21

        # sense to map it into skip some day.

    22

        self.ignored = []

    23

    24

        self.times = []

    25

        self._firststarttime = None

    26

        # Data stored for the benefit of generating xunit reports.

    27

        self.successes = []

    28

        self.faildata = {}

    29

    30

    def addFailure(self, test, reason):

    31

        print("FAILURE!", test, reason)

    32

    33

    def addSuccess(self, test):

    34

        print("SUCCESS!", test)

    35

    36

    def addError(self, test, err):

    37

        print("ERR!", test, err)

    38

    39

    # Polyfill.

    40

    def addSkip(self, test, reason):

    41

        print("SKIP!", test, reason)

    42

    43

    def addIgnore(self, test, reason):

    44

        print("IGNORE!", test, reason)

    45

    46

    def onStart(self, test):

    47

        print("ON_START!", test)

    48

    49

    def onEnd(self):

    50

        print("ON_END!")

    51

    52

    def addOutputMismatch(self, test, ret, got, expected):

    53

        return False

    54

    55

    def stopTest(self, test, interrupted=False):

    56

        super(TestResult, self).stopTest(test)