phases: avoid a potentially costly dictionary interation in some case If we retract for the draft phase, there is not non-public item to be retracted and we can skip this part. This part is was apparently super costly thanks to Python. On mozilla-try-2019-02-18, a perf::unbundle call with a 10 000 changesets bundle gives give use the following timing. e57d4b868a3e: 4.6 seconds ac1c75188440: 102.5 seconds this-changeset: 30.0 seconds So we recovered about ⅔ of the regression, the next changeset will give us the rest back.

     1

Issue351: mq: qrefresh can create extra revlog entry

     2

     3

  $ echo "[extensions]" >> $HGRCPATH

     4

  $ echo "mq=" >> $HGRCPATH

     5

     6

  $ hg init repo

     7

  $ cd repo

     8

  $ hg qinit

     9

    10

  $ echo b > b

    11

  $ hg ci -A -m foo

    12

  adding b

    13

    14

  $ echo cc > b

    15

  $ hg qnew -f foo.diff

    16

  $ echo b > b

    17

  $ hg qrefresh

    18

    19

  $ hg debugindex b

    20

     rev linkrev       nodeid    p1-nodeid    p2-nodeid

    21

       0       0 1e88685f5dde 000000000000 000000000000

    22