phases: avoid a potentially costly dictionary interation in some case If we retract for the draft phase, there is not non-public item to be retracted and we can skip this part. This part is was apparently super costly thanks to Python. On mozilla-try-2019-02-18, a perf::unbundle call with a 10 000 changesets bundle gives give use the following timing. e57d4b868a3e: 4.6 seconds ac1c75188440: 102.5 seconds this-changeset: 30.0 seconds So we recovered about ⅔ of the regression, the next changeset will give us the rest back.

     1

pager.pager=p0 # $TESTTMP/sysrc:4

     2

ui.editor=e1 # $TESTTMP/userrc:2

     3

     4

pager.pager=p2 # $PAGER

     5

ui.editor=e1 # $TESTTMP/userrc:2

     6