phases: avoid a potentially costly dictionary interation in some case If we retract for the draft phase, there is not non-public item to be retracted and we can skip this part. This part is was apparently super costly thanks to Python. On mozilla-try-2019-02-18, a perf::unbundle call with a 10 000 changesets bundle gives give use the following timing. e57d4b868a3e: 4.6 seconds ac1c75188440: 102.5 seconds this-changeset: 30.0 seconds So we recovered about ⅔ of the regression, the next changeset will give us the rest back.

     1

#require rustfmt test-repo

     2

     3

  $ . "$TESTDIR/helpers-testrepo.sh"

     4

     5

  $ cd "$TESTDIR"/..

     6

     7

Warning: Keep this in sync with hghave.py

     8

  $ RUSTFMT=$(rustup which --toolchain nightly-2021-11-02 rustfmt)

     9

  $ for f in `testrepohg files 'glob:**/*.rs'` ; do

    10

  >   $RUSTFMT --check --edition=2018 --unstable-features --color=never $f

    11

  > done