phases: avoid a potentially costly dictionary interation in some case If we retract for the draft phase, there is not non-public item to be retracted and we can skip this part. This part is was apparently super costly thanks to Python. On mozilla-try-2019-02-18, a perf::unbundle call with a 10 000 changesets bundle gives give use the following timing. e57d4b868a3e: 4.6 seconds ac1c75188440: 102.5 seconds this-changeset: 30.0 seconds So we recovered about ⅔ of the regression, the next changeset will give us the rest back.

     1

#include <Python.h>

     2

     3

#if PY_MAJOR_VERSION >= 3

     4

#define PYCODETYPE PyObject

     5

#else

     6

#define PYCODETYPE PyCodeObject

     7

#endif

     8

     9

namespace contrib

    10

{

    11

    12

void initpy(const char *cselfpath);

    13

PyObject *pyglobals();

    14

    15

} /* namespace contrib */