revset: stop serializing node when using "%ln" Turning hundred of thousand of node from node to hex and back can be slow… what about we stop doing it? In many case were we are using node id we should be using revision id. However this is not a good reason to have a stupidly slow implementation of "%ln". This caught my attention again because the phase discovery during push make an extensive use of "%ln" or huge set. In absolute, that phase discovery probably should use "%ld" and need to improves its algorithmic complexity, but improving "%ln" seems simple and long overdue. This greatly speeds up `hg push` on repository with many drafts. Here are some relevant poulpe benchmarks: ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # benchmark.name = hg.command.push # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.reuse-external-delta-parent = default ## benchmark.variants.revs = any-1-extra-rev before: 44.235070 after: 20.416329 (-53.85%, -23.82) ## benchmark.variants.revs = any-100-extra-rev before: 49.234697 after: 26.519829 (-46.14%, -22.71) ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 10.138396 after: 7.750458 (-23.55%, -2.39) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 1.263859 after: 0.700229 (-44.60%, -0.56) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 399.484481 after: 346.5089 (-13.26%, -52.98) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 4.540080 after: 3.401700 (-25.07%, -1.14) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 2.975765 after: 1.870798 (-37.13%, -1.10)

     1

Test wire protocol unbundle with hashed heads (capability: unbundlehash)

     2

     3

  $ cat << EOF >> $HGRCPATH

     4

  > [devel]

     5

  > # This tests is intended for bundle1 only.

     6

  > # bundle2 carries the head information inside the bundle itself and

     7

  > # always uses 'force' as the heads value.

     8

  > legacy.exchange = bundle1

     9

  > EOF

    10

    11

Create a remote repository.

    12

    13

  $ hg init remote

    14

  $ hg serve -R remote --config web.push_ssl=False --config web.allow_push=* -p $HGPORT -d --pid-file=hg1.pid -E error.log -A access.log

    15

  $ cat hg1.pid >> $DAEMON_PIDS

    16

    17

Clone the repository and push a change.

    18

    19

  $ hg clone http://localhost:$HGPORT/ local

    20

  no changes found

    21

  updating to branch default

    22

  0 files updated, 0 files merged, 0 files removed, 0 files unresolved

    23

  $ touch local/README

    24

  $ hg ci -R local -A -m hoge

    25

  adding README

    26

  $ hg push -R local

    27

  pushing to http://localhost:$HGPORT/

    28

  searching for changes

    29

  remote: adding changesets

    30

  remote: adding manifests

    31

  remote: adding file changes

    32

  remote: added 1 changesets with 1 changes to 1 files

    33

    34

Ensure hashed heads format is used.

    35

The hash here is always the same since the remote repository only has the null head.

    36

    37

  $ cat access.log | grep unbundle

    38

  * - - [*] "POST /?cmd=unbundle HTTP/1.1" 200 - x-hgarg-1:heads=686173686564+6768033e216468247bd031a0a2d9876d79818f8f* (glob)

    39

    40

Explicitly kill daemons to let the test exit on Windows

    41

    42

  $ killdaemons.py

    43