revset: stop serializing node when using "%ln" Turning hundred of thousand of node from node to hex and back can be slow… what about we stop doing it? In many case were we are using node id we should be using revision id. However this is not a good reason to have a stupidly slow implementation of "%ln". This caught my attention again because the phase discovery during push make an extensive use of "%ln" or huge set. In absolute, that phase discovery probably should use "%ld" and need to improves its algorithmic complexity, but improving "%ln" seems simple and long overdue. This greatly speeds up `hg push` on repository with many drafts. Here are some relevant poulpe benchmarks: ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # benchmark.name = hg.command.push # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.reuse-external-delta-parent = default ## benchmark.variants.revs = any-1-extra-rev before: 44.235070 after: 20.416329 (-53.85%, -23.82) ## benchmark.variants.revs = any-100-extra-rev before: 49.234697 after: 26.519829 (-46.14%, -22.71) ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 10.138396 after: 7.750458 (-23.55%, -2.39) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 1.263859 after: 0.700229 (-44.60%, -0.56) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 399.484481 after: 346.5089 (-13.26%, -52.98) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 4.540080 after: 3.401700 (-25.07%, -1.14) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 2.975765 after: 1.870798 (-37.13%, -1.10)

     1

#testcases dirstate-v1 dirstate-v2

     2

     3

#if dirstate-v2

     4

  $ cat >> $HGRCPATH << EOF

     5

  > [format]

     6

  > use-dirstate-v2=1

     7

  > [storage]

     8

  > dirstate-v2.slow-path=allow

     9

  > EOF

    10

#endif

    11

    12

    13

The proliferation of status implementations can be confusing:

    14

- The pure python implementation:

    15

(no-rhg pure !)

    16

- The C implementation:

    17

(no-rhg no-rust no-pure !)

    18

- The two rust implementations:

    19

(rhg !)

    20

(no-rhg rust !)

    21

    22

  $ hg init repo1

    23

  $ cd repo1

    24

  $ mkdir d1

    25

  $ touch d1/x

    26

  $ hg commit -Am.

    27

  adding d1/x

    28

  $ touch d1/y

    29

  $ chmod -r d1

    30

  $ hg status

    31

  d1: $EACCES$

    32

  ! d1/x (rhg !)

    33

  ! d1/x (no-rhg rust !)

    34

  $ hg status

    35

  d1: $EACCES$

    36

  ! d1/x (rust !)

    37

  ! d1/x (no-rust rhg !)

    38

  $ chmod +r d1

    39

  $ hg status

    40

  ? d1/y

    41

    42

  $ touch d1/z

    43

  $ hg status

    44

  ? d1/y

    45

  ? d1/z