revset: stop serializing node when using "%ln" Turning hundred of thousand of node from node to hex and back can be slow… what about we stop doing it? In many case were we are using node id we should be using revision id. However this is not a good reason to have a stupidly slow implementation of "%ln". This caught my attention again because the phase discovery during push make an extensive use of "%ln" or huge set. In absolute, that phase discovery probably should use "%ld" and need to improves its algorithmic complexity, but improving "%ln" seems simple and long overdue. This greatly speeds up `hg push` on repository with many drafts. Here are some relevant poulpe benchmarks: ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # benchmark.name = hg.command.push # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.reuse-external-delta-parent = default ## benchmark.variants.revs = any-1-extra-rev before: 44.235070 after: 20.416329 (-53.85%, -23.82) ## benchmark.variants.revs = any-100-extra-rev before: 49.234697 after: 26.519829 (-46.14%, -22.71) ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 10.138396 after: 7.750458 (-23.55%, -2.39) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 1.263859 after: 0.700229 (-44.60%, -0.56) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 399.484481 after: 346.5089 (-13.26%, -52.98) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 4.540080 after: 3.401700 (-25.07%, -1.14) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 2.975765 after: 1.870798 (-37.13%, -1.10)

     1

Issue1678: IndexError when pushing

     2

     3

setting up base repo

     4

  $ hg init a

     5

  $ cd a

     6

  $ touch a

     7

  $ hg ci -Am a

     8

  adding a

     9

  $ cd ..

    10

    11

cloning base repo

    12

  $ hg clone a b

    13

  updating to branch default

    14

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    15

  $ cd b

    16

    17

setting up cset to push

    18

  $ hg up null

    19

  0 files updated, 0 files merged, 1 files removed, 0 files unresolved

    20

  $ touch a

    21

different msg so we get a clog new entry

    22

  $ hg ci -Am b

    23

  adding a

    24

  created new head

    25

    26

pushing

    27

  $ hg push -f ../a

    28

  pushing to ../a

    29

  searching for changes

    30

  adding changesets

    31

  adding manifests

    32

  adding file changes

    33

  added 1 changesets with 0 changes to 0 files (+1 heads)

    34

    35

  $ cd ..