revset: stop serializing node when using "%ln" Turning hundred of thousand of node from node to hex and back can be slow… what about we stop doing it? In many case were we are using node id we should be using revision id. However this is not a good reason to have a stupidly slow implementation of "%ln". This caught my attention again because the phase discovery during push make an extensive use of "%ln" or huge set. In absolute, that phase discovery probably should use "%ld" and need to improves its algorithmic complexity, but improving "%ln" seems simple and long overdue. This greatly speeds up `hg push` on repository with many drafts. Here are some relevant poulpe benchmarks: ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # benchmark.name = hg.command.push # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.reuse-external-delta-parent = default ## benchmark.variants.revs = any-1-extra-rev before: 44.235070 after: 20.416329 (-53.85%, -23.82) ## benchmark.variants.revs = any-100-extra-rev before: 49.234697 after: 26.519829 (-46.14%, -22.71) ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 10.138396 after: 7.750458 (-23.55%, -2.39) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 1.263859 after: 0.700229 (-44.60%, -0.56) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 399.484481 after: 346.5089 (-13.26%, -52.98) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 4.540080 after: 3.401700 (-25.07%, -1.14) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 2.975765 after: 1.870798 (-37.13%, -1.10)

     1

#require no-windows

     2

     3

  $ . "$TESTDIR/remotefilelog-library.sh"

     4

     5

  $ hg init master

     6

  $ cd master

     7

  $ cat >> .hg/hgrc <<EOF

     8

  > [remotefilelog]

     9

  > server=True

    10

  > EOF

    11

  $ echo x > x

    12

  $ hg commit -qAm x

    13

  $ echo y >> x

    14

  $ hg commit -qAm y

    15

  $ echo z >> x

    16

  $ hg commit -qAm z

    17

  $ hg update 1

    18

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    19

  $ echo w >> x

    20

  $ hg commit -qAm w

    21

    22

  $ cd ..

    23

    24

Shallow clone and activate getflogheads testing extension

    25

    26

  $ hgcloneshallow ssh://user@dummy/master shallow --noupdate

    27

  streaming all changes

    28

  3 files to transfer, 908 bytes of data (no-rust !)

    29

  transferred 908 bytes in * seconds (*/sec) (glob) (no-rust !)

    30

  5 files to transfer, 1.01 KB of data (rust !)

    31

  transferred 1.01 KB in * seconds (* */sec) (glob) (rust !)

    32

  searching for changes

    33

  no changes found

    34

  $ cd shallow

    35

    36

  $ cat >> .hg/hgrc <<EOF

    37

  > [extensions]

    38

  > getflogheads=$TESTDIR/remotefilelog-getflogheads.py

    39

  > EOF

    40

    41

Get heads of a remotefilelog

    42

    43

  $ hg getflogheads x

    44

  2797809ca5e9c2f307d82b1345e832f655fb99a2

    45

  ca758b402ddc91e37e3113e1a97791b537e1b7bb

    46

    47

Get heads of a non-existing remotefilelog

    48

    49

  $ hg getflogheads y

    50

  EMPTY