revset: stop serializing node when using "%ln" Turning hundred of thousand of node from node to hex and back can be slow… what about we stop doing it? In many case were we are using node id we should be using revision id. However this is not a good reason to have a stupidly slow implementation of "%ln". This caught my attention again because the phase discovery during push make an extensive use of "%ln" or huge set. In absolute, that phase discovery probably should use "%ld" and need to improves its algorithmic complexity, but improving "%ln" seems simple and long overdue. This greatly speeds up `hg push` on repository with many drafts. Here are some relevant poulpe benchmarks: ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # benchmark.name = hg.command.push # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.reuse-external-delta-parent = default ## benchmark.variants.revs = any-1-extra-rev before: 44.235070 after: 20.416329 (-53.85%, -23.82) ## benchmark.variants.revs = any-100-extra-rev before: 49.234697 after: 26.519829 (-46.14%, -22.71) ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 10.138396 after: 7.750458 (-23.55%, -2.39) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 1.263859 after: 0.700229 (-44.60%, -0.56) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 399.484481 after: 346.5089 (-13.26%, -52.98) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 4.540080 after: 3.401700 (-25.07%, -1.14) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 2.975765 after: 1.870798 (-37.13%, -1.10)

     1

#require no-windows

     2

     3

  $ . "$TESTDIR/remotefilelog-library.sh"

     4

     5

  $ hg init master

     6

  $ cd master

     7

  $ cat >> .hg/hgrc <<EOF

     8

  > [remotefilelog]

     9

  > server=True

    10

  > EOF

    11

  $ echo x > x

    12

  $ hg commit -qAm x

    13

    14

  $ cd ..

    15

    16

  $ hgcloneshallow ssh://user@dummy/master shallow -q

    17

  1 files fetched over 1 fetches - (1 misses, 0.00% hit ratio) over *s (glob)

    18

  $ cd shallow

    19

    20

  $ cat >> $TESTTMP/get_file_linknode.py <<EOF

    21

  > from mercurial import node, registrar, scmutil

    22

  > cmdtable = {}

    23

  > command = registrar.command(cmdtable)

    24

  > @command(b'debug-file-linknode', [(b'r', b'rev', b'.', b'rev')], b'hg debug-file-linknode FILE')

    25

  > def debug_file_linknode(ui, repo, file, **opts):

    26

  >   rflctx = scmutil.revsingle(repo.unfiltered(), opts['rev']).filectx(file)

    27

  >   ui.status(b'%s\n' % node.hex(rflctx.ancestormap()[rflctx._filenode][2]))

    28

  > EOF

    29

    30

  $ cat >> .hg/hgrc <<EOF

    31

  > [ui]

    32

  > interactive=1

    33

  > [extensions]

    34

  > strip=

    35

  > get_file_linknode=$TESTTMP/get_file_linknode.py

    36

  > [experimental]

    37

  > evolution=createmarkers,allowunstable

    38

  > EOF

    39

  $ echo a > a

    40

  $ hg commit -qAm msg1

    41

  $ hg commit --amend 're:^$' -m msg2

    42

  $ hg commit --amend 're:^$' -m msg3

    43

  $ hg --hidden log -G -T '{rev} {node|short}'

    44

  @  3 df91f74b871e

    45

  |

    46

  | x  2 70494d7ec5ef

    47

  |/

    48

  | x  1 1e423846dde0

    49

  |/

    50

  o  0 b292c1e3311f

    51

    52

  $ hg debug-file-linknode -r 70494d a

    53

  df91f74b871e064c89afa1fe9e2f66afa2c125df

    54

  $ hg --hidden strip -r 1 3

    55

  0 files updated, 0 files merged, 1 files removed, 0 files unresolved

    56

  saved backup bundle to $TESTTMP/shallow/.hg/strip-backup/df91f74b871e-c94d67be-backup.hg

    57

    58

  $ hg --hidden log -G -T '{rev} {node|short}'

    59

  o  1 70494d7ec5ef

    60

  |

    61

  @  0 b292c1e3311f

    62

    63

Demonstrate that the linknode points to a commit that is actually in the repo

    64

after the strip operation. Otherwise remotefilelog has to search every commit in

    65

the repository looking for a valid linkrev every time it's queried, such as

    66

during push.

    67

  $ hg debug-file-linknode -r 70494d a

    68

  70494d7ec5ef6cd3cd6939a9fd2812f9956bf553