revset: stop serializing node when using "%ln" Turning hundred of thousand of node from node to hex and back can be slow… what about we stop doing it? In many case were we are using node id we should be using revision id. However this is not a good reason to have a stupidly slow implementation of "%ln". This caught my attention again because the phase discovery during push make an extensive use of "%ln" or huge set. In absolute, that phase discovery probably should use "%ld" and need to improves its algorithmic complexity, but improving "%ln" seems simple and long overdue. This greatly speeds up `hg push` on repository with many drafts. Here are some relevant poulpe benchmarks: ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # benchmark.name = hg.command.push # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.reuse-external-delta-parent = default ## benchmark.variants.revs = any-1-extra-rev before: 44.235070 after: 20.416329 (-53.85%, -23.82) ## benchmark.variants.revs = any-100-extra-rev before: 49.234697 after: 26.519829 (-46.14%, -22.71) ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 10.138396 after: 7.750458 (-23.55%, -2.39) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 1.263859 after: 0.700229 (-44.60%, -0.56) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 399.484481 after: 346.5089 (-13.26%, -52.98) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 4.540080 after: 3.401700 (-25.07%, -1.14) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 2.975765 after: 1.870798 (-37.13%, -1.10)

     1

  $ cat << EOF >> $HGRCPATH

     2

  > [extensions]

     3

  > rebase=

     4

  > [alias]

     5

  > tglog = log -G -T "{rev} '{desc}'\n"

     6

  > EOF

     7

     8

  $ hg init

     9

    10

  $ echo a > a; hg add a; hg ci -m a

    11

  $ echo b > b; hg add b; hg ci -m b1

    12

  $ hg up 0 -q

    13

  $ echo b > b; hg add b; hg ci -m b2 -q

    14

    15

  $ hg tglog

    16

  @  2 'b2'

    17

  |

    18

  | o  1 'b1'

    19

  |/

    20

  o  0 'a'

    21

    22

    23

With rewrite.empty-successor=skip, b2 is skipped because it would become empty.

    24

    25

  $ hg rebase -s 2 -d 1 --config rewrite.empty-successor=skip --dry-run

    26

  starting dry-run rebase; repository will not be changed

    27

  rebasing 2:6e2aad5e0f3c tip "b2"

    28

  note: not rebasing 2:6e2aad5e0f3c tip "b2", its destination already has all its changes

    29

  dry-run rebase completed successfully; run without -n/--dry-run to perform this rebase

    30

    31

With rewrite.empty-successor=keep, b2 will be recreated although it became empty.

    32

    33

  $ hg rebase -s 2 -d 1 --config rewrite.empty-successor=keep

    34

  rebasing 2:6e2aad5e0f3c tip "b2"

    35

  note: created empty successor for 2:6e2aad5e0f3c tip "b2", its destination already has all its changes

    36

  saved backup bundle to $TESTTMP/.hg/strip-backup/6e2aad5e0f3c-7d7c8801-rebase.hg

    37

    38

  $ hg tglog

    39

  @  2 'b2'

    40

  |

    41

  o  1 'b1'

    42

  |

    43

  o  0 'a'

    44