revset: stop serializing node when using "%ln" Turning hundred of thousand of node from node to hex and back can be slow… what about we stop doing it? In many case were we are using node id we should be using revision id. However this is not a good reason to have a stupidly slow implementation of "%ln". This caught my attention again because the phase discovery during push make an extensive use of "%ln" or huge set. In absolute, that phase discovery probably should use "%ld" and need to improves its algorithmic complexity, but improving "%ln" seems simple and long overdue. This greatly speeds up `hg push` on repository with many drafts. Here are some relevant poulpe benchmarks: ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # benchmark.name = hg.command.push # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.reuse-external-delta-parent = default ## benchmark.variants.revs = any-1-extra-rev before: 44.235070 after: 20.416329 (-53.85%, -23.82) ## benchmark.variants.revs = any-100-extra-rev before: 49.234697 after: 26.519829 (-46.14%, -22.71) ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 10.138396 after: 7.750458 (-23.55%, -2.39) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 1.263859 after: 0.700229 (-44.60%, -0.56) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 399.484481 after: 346.5089 (-13.26%, -52.98) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 4.540080 after: 3.401700 (-25.07%, -1.14) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 2.975765 after: 1.870798 (-37.13%, -1.10)

     1

  $ . "$TESTDIR/narrow-library.sh"

     2

  $ hg init master

     3

  $ cd master

     4

  $ echo treemanifest >> .hg/requires

     5

  $ echo 'contents of file' > file

     6

  $ mkdir foo

     7

  $ echo 'contents of foo/bar' > foo/bar

     8

  $ hg ci -Am 'some change'

     9

  adding file

    10

  adding foo/bar

    11

    12

  $ cd ..

    13

  $ hg clone --narrow ssh://user@dummy/master copy --include=foo

    14

  requesting all changes

    15

  adding changesets

    16

  adding manifests

    17

  adding file changes

    18

  added 1 changesets with 1 changes to 1 files

    19

  new changesets * (glob)

    20

  updating to branch default

    21

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    22

  $ cd copy

    23

    24

  $ hg debugdirstate --no-dates

    25

  n *         20 *               foo/bar (glob)

    26

  $ mv .hg/dirstate .hg/old_dirstate

    27

  $ dd bs=40 count=1 if=.hg/old_dirstate of=.hg/dirstate 2>/dev/null

    28

  $ hg debugdirstate

    29

  $ hg debugrebuilddirstate

    30

  $ hg debugdirstate

    31

  n *         * unset               foo/bar (glob)