revset: stop serializing node when using "%ln" Turning hundred of thousand of node from node to hex and back can be slow… what about we stop doing it? In many case were we are using node id we should be using revision id. However this is not a good reason to have a stupidly slow implementation of "%ln". This caught my attention again because the phase discovery during push make an extensive use of "%ln" or huge set. In absolute, that phase discovery probably should use "%ld" and need to improves its algorithmic complexity, but improving "%ln" seems simple and long overdue. This greatly speeds up `hg push` on repository with many drafts. Here are some relevant poulpe benchmarks: ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # benchmark.name = hg.command.push # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.reuse-external-delta-parent = default ## benchmark.variants.revs = any-1-extra-rev before: 44.235070 after: 20.416329 (-53.85%, -23.82) ## benchmark.variants.revs = any-100-extra-rev before: 49.234697 after: 26.519829 (-46.14%, -22.71) ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 10.138396 after: 7.750458 (-23.55%, -2.39) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 1.263859 after: 0.700229 (-44.60%, -0.56) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 399.484481 after: 346.5089 (-13.26%, -52.98) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 4.540080 after: 3.401700 (-25.07%, -1.14) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 2.975765 after: 1.870798 (-37.13%, -1.10)

     1

Make a narrow clone then archive it

     2

  $ . "$TESTDIR/narrow-library.sh"

     3

     4

  $ hg init master

     5

  $ cd master

     6

     7

  $ for x in `$TESTDIR/seq.py 3`; do

     8

  >   echo $x > "f$x"

     9

  >   hg add "f$x"

    10

  >   hg commit -m "Add $x"

    11

  > done

    12

    13

  $ hg serve -a localhost -p $HGPORT1 -d --pid-file=hg.pid

    14

  $ cat hg.pid >> "$DAEMON_PIDS"

    15

    16

  $ cd ..

    17

  $ hg clone --narrow --include f1 --include f2 http://localhost:$HGPORT1/ narrowclone1

    18

  requesting all changes

    19

  adding changesets

    20

  adding manifests

    21

  adding file changes

    22

  added 3 changesets with 2 changes to 2 files

    23

  new changesets * (glob)

    24

  updating to branch default

    25

  2 files updated, 0 files merged, 0 files removed, 0 files unresolved

    26

    27

The tar should only contain f1 and f2

    28

  $ cd narrowclone1

    29

  $ hg archive -t tgz repo.tgz

    30

  $ tar tfz repo.tgz

    31

  repo/f1

    32

  repo/f2