revset: stop serializing node when using "%ln" Turning hundred of thousand of node from node to hex and back can be slow… what about we stop doing it? In many case were we are using node id we should be using revision id. However this is not a good reason to have a stupidly slow implementation of "%ln". This caught my attention again because the phase discovery during push make an extensive use of "%ln" or huge set. In absolute, that phase discovery probably should use "%ld" and need to improves its algorithmic complexity, but improving "%ln" seems simple and long overdue. This greatly speeds up `hg push` on repository with many drafts. Here are some relevant poulpe benchmarks: ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # benchmark.name = hg.command.push # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.reuse-external-delta-parent = default ## benchmark.variants.revs = any-1-extra-rev before: 44.235070 after: 20.416329 (-53.85%, -23.82) ## benchmark.variants.revs = any-100-extra-rev before: 49.234697 after: 26.519829 (-46.14%, -22.71) ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 10.138396 after: 7.750458 (-23.55%, -2.39) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 1.263859 after: 0.700229 (-44.60%, -0.56) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 399.484481 after: 346.5089 (-13.26%, -52.98) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 4.540080 after: 3.401700 (-25.07%, -1.14) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 2.975765 after: 1.870798 (-37.13%, -1.10)

     1

  $ cat <<EOF >> $HGRCPATH

     2

  > [extensions]

     3

  > purge =

     4

  > EOF

     5

     6

  $ hg init test

     7

  $ cd test

     8

  $ echo a > changed

     9

  $ echo a > removed

    10

  $ echo a > source

    11

  $ hg ci -Am addfiles

    12

  adding changed

    13

  adding removed

    14

  adding source

    15

  $ echo a >> changed

    16

  $ echo a > added

    17

  $ hg add added

    18

  $ hg rm removed

    19

  $ hg cp source copied

    20

  $ hg diff --git > ../unknown.diff

    21

    22

Test adding on top of an unknown file

    23

    24

  $ hg up -qC 0

    25

  $ hg purge

    26

  $ echo a > added

    27

  $ hg import --no-commit ../unknown.diff

    28

  applying ../unknown.diff

    29

  file added already exists

    30

  1 out of 1 hunks FAILED -- saving rejects to file added.rej

    31

  abort: patch failed to apply

    32

  [20]

    33

    34

Test modifying an unknown file

    35

    36

  $ hg revert -aq

    37

  $ hg purge

    38

  $ hg rm changed

    39

  $ hg ci -m removechanged

    40

  $ echo a > changed

    41

  $ hg import --no-commit ../unknown.diff

    42

  applying ../unknown.diff

    43

  abort: cannot patch changed: file is not tracked

    44

  [20]

    45

    46

Test removing an unknown file

    47

    48

  $ hg up -qC 0

    49

  $ hg purge

    50

  $ hg rm removed

    51

  $ hg ci -m removeremoved

    52

  created new head

    53

  $ echo a > removed

    54

  $ hg import --no-commit ../unknown.diff

    55

  applying ../unknown.diff

    56

  abort: cannot patch removed: file is not tracked

    57

  [20]

    58

    59

Test copying onto an unknown file

    60

    61

  $ hg up -qC 0

    62

  $ hg purge

    63

  $ echo a > copied

    64

  $ hg import --no-commit ../unknown.diff

    65

  applying ../unknown.diff

    66

  abort: cannot create copied: destination already exists

    67

  [20]

    68

    69

  $ cd ..