revset: stop serializing node when using "%ln" Turning hundred of thousand of node from node to hex and back can be slow… what about we stop doing it? In many case were we are using node id we should be using revision id. However this is not a good reason to have a stupidly slow implementation of "%ln". This caught my attention again because the phase discovery during push make an extensive use of "%ln" or huge set. In absolute, that phase discovery probably should use "%ld" and need to improves its algorithmic complexity, but improving "%ln" seems simple and long overdue. This greatly speeds up `hg push` on repository with many drafts. Here are some relevant poulpe benchmarks: ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # benchmark.name = hg.command.push # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.reuse-external-delta-parent = default ## benchmark.variants.revs = any-1-extra-rev before: 44.235070 after: 20.416329 (-53.85%, -23.82) ## benchmark.variants.revs = any-100-extra-rev before: 49.234697 after: 26.519829 (-46.14%, -22.71) ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 10.138396 after: 7.750458 (-23.55%, -2.39) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 1.263859 after: 0.700229 (-44.60%, -0.56) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 399.484481 after: 346.5089 (-13.26%, -52.98) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 4.540080 after: 3.401700 (-25.07%, -1.14) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 2.975765 after: 1.870798 (-37.13%, -1.10)

     1

  $ cat <<EOF >> $HGRCPATH

     2

  > [extensions]

     3

  > hooklib =

     4

  > 

     5

  > [phases]

     6

  > publish = False

     7

  > EOF

     8

  $ hg init a

     9

  $ hg --cwd a debugbuilddag .

    10

  $ hg --cwd a phase --public 0

    11

  $ hg init b

    12

  $ cat <<EOF >> b/.hg/hgrc

    13

  > [hooks]

    14

  > pretxnclose-phase.enforce_draft_commits = \

    15

  >   python:hgext.hooklib.enforce_draft_commits.hook

    16

  > EOF

    17

  $ hg --cwd b pull ../a

    18

  pulling from ../a

    19

  requesting all changes

    20

  adding changesets

    21

  adding manifests

    22

  adding file changes

    23

  error: pretxnclose-phase.enforce_draft_commits hook failed: New changeset 1ea73414a91b in phase 'public' rejected

    24

  transaction abort!

    25

  rollback completed

    26

  abort: New changeset 1ea73414a91b in phase 'public' rejected

    27

  [255]

    28

  $ hg --cwd a phase --force --draft 0

    29

  $ hg --cwd b pull ../a

    30

  pulling from ../a

    31

  requesting all changes

    32

  adding changesets

    33

  adding manifests

    34

  adding file changes

    35

  added 1 changesets with 0 changes to 0 files

    36

  new changesets 1ea73414a91b (1 drafts)

    37

  (run 'hg update' to get a working copy)

    38

  $ hg --cwd a phase --public 0

    39

  $ hg --cwd b pull ../a

    40

  pulling from ../a

    41

  searching for changes

    42

  no changes found

    43

  error: pretxnclose-phase.enforce_draft_commits hook failed: Phase change from 'draft' to 'public' for 1ea73414a91b rejected

    44

  abort: Phase change from 'draft' to 'public' for 1ea73414a91b rejected

    45

  [255]