revset: stop serializing node when using "%ln" Turning hundred of thousand of node from node to hex and back can be slow… what about we stop doing it? In many case were we are using node id we should be using revision id. However this is not a good reason to have a stupidly slow implementation of "%ln". This caught my attention again because the phase discovery during push make an extensive use of "%ln" or huge set. In absolute, that phase discovery probably should use "%ld" and need to improves its algorithmic complexity, but improving "%ln" seems simple and long overdue. This greatly speeds up `hg push` on repository with many drafts. Here are some relevant poulpe benchmarks: ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # benchmark.name = hg.command.push # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.reuse-external-delta-parent = default ## benchmark.variants.revs = any-1-extra-rev before: 44.235070 after: 20.416329 (-53.85%, -23.82) ## benchmark.variants.revs = any-100-extra-rev before: 49.234697 after: 26.519829 (-46.14%, -22.71) ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 10.138396 after: 7.750458 (-23.55%, -2.39) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 1.263859 after: 0.700229 (-44.60%, -0.56) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 399.484481 after: 346.5089 (-13.26%, -52.98) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 4.540080 after: 3.401700 (-25.07%, -1.14) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 2.975765 after: 1.870798 (-37.13%, -1.10)

     1

A script that implements uppercasing all letters in a file.

     2

     3

  $ UPPERCASEPY="$TESTTMP/uppercase.py"

     4

  $ cat > $UPPERCASEPY <<EOF

     5

  > import sys

     6

  > from mercurial.utils.procutil import setbinary

     7

  > setbinary(sys.stdin)

     8

  > setbinary(sys.stdout)

     9

  > sys.stdout.write(sys.stdin.read().upper())

    10

  > EOF

    11

  $ TESTLINES="foo\nbar\nbaz\n"

    12

  $ printf $TESTLINES | "$PYTHON" $UPPERCASEPY

    13

  FOO

    14

  BAR

    15

  BAZ

    16

    17

This file attempts to test our workarounds for pickle's lack of

    18

support for short reads.

    19

    20

  $ cat >> $HGRCPATH <<EOF

    21

  > [extensions]

    22

  > fix =

    23

  > [fix]

    24

  > uppercase-whole-file:command="$PYTHON" $UPPERCASEPY

    25

  > uppercase-whole-file:pattern=set:**

    26

  > EOF

    27

    28

  $ hg init repo

    29

  $ cd repo

    30

    31

# Create a file that's large enough that it seems to not fit in

    32

# pickle's buffer, making it use the code path that expects our

    33

# _blockingreader's read() method to return bytes.

    34

  $ echo "some stuff" > file

    35

  $ for i in $($TESTDIR/seq.py 13); do

    36

  >   cat file file > tmp

    37

  >   mv -f tmp file

    38

  > done

    39

  $ hg commit -Am "add large file"

    40

  adding file

    41

    42

Check that we don't get a crash

    43

    44

  $ hg fix -r .

    45

  saved backup bundle to $TESTTMP/repo/.hg/strip-backup/*-fix.hg (glob)