revset: stop serializing node when using "%ln" Turning hundred of thousand of node from node to hex and back can be slow… what about we stop doing it? In many case were we are using node id we should be using revision id. However this is not a good reason to have a stupidly slow implementation of "%ln". This caught my attention again because the phase discovery during push make an extensive use of "%ln" or huge set. In absolute, that phase discovery probably should use "%ld" and need to improves its algorithmic complexity, but improving "%ln" seems simple and long overdue. This greatly speeds up `hg push` on repository with many drafts. Here are some relevant poulpe benchmarks: ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # benchmark.name = hg.command.push # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.reuse-external-delta-parent = default ## benchmark.variants.revs = any-1-extra-rev before: 44.235070 after: 20.416329 (-53.85%, -23.82) ## benchmark.variants.revs = any-100-extra-rev before: 49.234697 after: 26.519829 (-46.14%, -22.71) ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 10.138396 after: 7.750458 (-23.55%, -2.39) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 1.263859 after: 0.700229 (-44.60%, -0.56) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 399.484481 after: 346.5089 (-13.26%, -52.98) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 4.540080 after: 3.401700 (-25.07%, -1.14) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 2.975765 after: 1.870798 (-37.13%, -1.10)

     1

Test admin::verify

     2

     3

  $ hg init admin-verify

     4

  $ cd admin-verify

     5

     6

Test normal output

     7

     8

  $ hg admin::verify -c dirstate

     9

  running 1 checks

    10

  running working-copy.dirstate

    11

  checking dirstate

    12

    13

Quiet works

    14

    15

  $ hg admin::verify -c dirstate --quiet

    16

    17

Test no check no options

    18

    19

  $ hg admin::verify

    20

  abort: `checks` required

    21

  [255]

    22

    23

Test single check without options

    24

    25

  $ hg admin::verify -c working-copy.dirstate

    26

  running 1 checks

    27

  running working-copy.dirstate

    28

  checking dirstate

    29

    30

Test single check (alias) without options

    31

    32

  $ hg admin::verify -c dirstate

    33

  running 1 checks

    34

  running working-copy.dirstate

    35

  checking dirstate

    36

    37

Test wrong check name without options

    38

    39

  $ hg admin::verify -c working-copy.dir

    40

  abort: unknown check working-copy.dir

    41

  (did you mean working-copy.dirstate?)

    42

  [10]

    43

    44

Test wrong alias without options

    45

    46

  $ hg admin::verify -c dir

    47

  abort: unknown check dir

    48

  [10]

    49