revset: stop serializing node when using "%ln" Turning hundred of thousand of node from node to hex and back can be slow… what about we stop doing it? In many case were we are using node id we should be using revision id. However this is not a good reason to have a stupidly slow implementation of "%ln". This caught my attention again because the phase discovery during push make an extensive use of "%ln" or huge set. In absolute, that phase discovery probably should use "%ld" and need to improves its algorithmic complexity, but improving "%ln" seems simple and long overdue. This greatly speeds up `hg push` on repository with many drafts. Here are some relevant poulpe benchmarks: ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # benchmark.name = hg.command.push # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.reuse-external-delta-parent = default ## benchmark.variants.revs = any-1-extra-rev before: 44.235070 after: 20.416329 (-53.85%, -23.82) ## benchmark.variants.revs = any-100-extra-rev before: 49.234697 after: 26.519829 (-46.14%, -22.71) ### benchmark.name = hg.command.bundle # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.revs = all # benchmark.variants.type = none-streamv2 ## data-env-vars.name = heptapod-public-2024-03-25-zstd-sparse-revlog before: 10.138396 after: 7.750458 (-23.55%, -2.39) ## data-env-vars.name = mercurial-public-2024-03-22-zstd-sparse-revlog before: 1.263859 after: 0.700229 (-44.60%, -0.56) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog before: 399.484481 after: 346.5089 (-13.26%, -52.98) ## data-env-vars.name = pypy-2024-03-22-zstd-sparse-revlog before: 4.540080 after: 3.401700 (-25.07%, -1.14) ## data-env-vars.name = tryton-public-2024-03-22-zstd-sparse-revlog before: 2.975765 after: 1.870798 (-37.13%, -1.10)

     1

DOCUMENT_ROOT="/var/www/hg"; export DOCUMENT_ROOT

     2

GATEWAY_INTERFACE="CGI/1.1"; export GATEWAY_INTERFACE

     3

HTTP_ACCEPT="text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5"; export HTTP_ACCEPT

     4

HTTP_ACCEPT_CHARSET="ISO-8859-1,utf-8;q=0.7,*;q=0.7"; export HTTP_ACCEPT_CHARSET

     5

HTTP_ACCEPT_ENCODING="gzip,deflate"; export HTTP_ACCEPT_ENCODING

     6

HTTP_ACCEPT_LANGUAGE="en-us,en;q=0.5"; export HTTP_ACCEPT_LANGUAGE

     7

HTTP_CACHE_CONTROL="max-age=0"; export HTTP_CACHE_CONTROL

     8

HTTP_CONNECTION="keep-alive"; export HTTP_CONNECTION

     9

HTTP_HOST="hg.omnifarious.org"; export HTTP_HOST

    10

HTTP_KEEP_ALIVE="300"; export HTTP_KEEP_ALIVE

    11

HTTP_USER_AGENT="Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.0.4) Gecko/20060608 Ubuntu/dapper-security Firefox/1.5.0.4"; export HTTP_USER_AGENT

    12

PATH_INFO="/"; export PATH_INFO

    13

PATH_TRANSLATED="/var/www/hg/index.html"; export PATH_TRANSLATED

    14

QUERY_STRING=""; export QUERY_STRING

    15

REMOTE_ADDR="127.0.0.2"; export REMOTE_ADDR

    16

REMOTE_PORT="44703"; export REMOTE_PORT

    17

REQUEST_METHOD="GET"; export REQUEST_METHOD

    18

REQUEST_URI="/test/"; export REQUEST_URI

    19

SCRIPT_FILENAME="/home/hopper/hg_public/test.cgi"; export SCRIPT_FILENAME

    20

SCRIPT_NAME="/test"; export SCRIPT_NAME

    21

SCRIPT_URI="http://hg.omnifarious.org/test/"; export SCRIPT_URI

    22

SCRIPT_URL="/test/"; export SCRIPT_URL

    23

SERVER_ADDR="127.0.0.1"; export SERVER_ADDR

    24

SERVER_ADMIN="eric@localhost"; export SERVER_ADMIN

    25

SERVER_NAME="hg.omnifarious.org"; export SERVER_NAME

    26

SERVER_PORT="80"; export SERVER_PORT

    27

SERVER_PROTOCOL="HTTP/1.1"; export SERVER_PROTOCOL

    28

SERVER_SIGNATURE="<address>Apache/2.0.53 (Fedora) Server at hg.omnifarious.org Port 80</address>"; export SERVER_SIGNATURE

    29

SERVER_SOFTWARE="Apache/2.0.53 (Fedora)"; export SERVER_SOFTWARE