hg: obtain lock when creating share from pooled repo (issue5104) There are race conditions between clients performing a shared clone to pooled storage: 1) Clients race to create the new shared repo in the pool directory 2) 1 client is seeding the repo in the pool directory and another goes to share it before it is fully cloned We prevent these race conditions by obtaining a lock in the pool directory that is derived from the name of the repo we will be accessing. To test this, a simple generic "lockdelay" extension has been added. The extension inserts an optional, configurable delay before or after lock acquisition. In the test, we delay 2 seconds after lock acquisition in the first process and 1 second before lock acquisition in the 2nd process. This means the first process has 1s to obtain the lock. There is a race condition here. If we encounter it in the wild, we could change the dummy extension to wait on the lock file to appear instead of relying on timing. But that's more complicated. Let's see what happens first.

     1

#require execbit

     2

     3

  $ hg init

     4

  $ echo a > a

     5

  $ hg ci -Am'not executable'

     6

  adding a

     7

     8

  $ chmod +x a

     9

  $ hg ci -m'executable'

    10

  $ hg id

    11

  79abf14474dc tip

    12

    13

Make sure we notice the change of mode if the cached size == -1:

    14

    15

  $ hg rm a

    16

  $ hg revert -r 0 a

    17

  $ hg debugstate

    18

  n   0         -1 unset               a

    19

  $ hg status

    20

  M a

    21

    22

  $ hg up 0

    23

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    24

  $ hg id

    25

  d69afc33ff8a

    26

  $ test -x a && echo executable -- bad || echo not executable -- good

    27

  not executable -- good

    28