hg: obtain lock when creating share from pooled repo (issue5104) There are race conditions between clients performing a shared clone to pooled storage: 1) Clients race to create the new shared repo in the pool directory 2) 1 client is seeding the repo in the pool directory and another goes to share it before it is fully cloned We prevent these race conditions by obtaining a lock in the pool directory that is derived from the name of the repo we will be accessing. To test this, a simple generic "lockdelay" extension has been added. The extension inserts an optional, configurable delay before or after lock acquisition. In the test, we delay 2 seconds after lock acquisition in the first process and 1 second before lock acquisition in the 2nd process. This means the first process has 1s to obtain the lock. There is a race condition here. If we encounter it in the wild, we could change the dummy extension to wait on the lock file to appear instead of relying on timing. But that's more complicated. Let's see what happens first.

     1

#require test-repo

     2

     3

  $ check_code="$TESTDIR"/../contrib/check-code.py

     4

  $ cd "$TESTDIR"/..

     5

     6

New errors are not allowed. Warnings are strongly discouraged.

     7

(The writing "no-che?k-code" is for not skipping this file when checking.)

     8

     9

  $ hg locate | sed 's-\\-/-g' |

    10

  >   xargs "$check_code" --warnings --per-file=0 || false

    11

  Skipping hgext/zeroconf/Zeroconf.py it has no-che?k-code (glob)

    12

  Skipping i18n/polib.py it has no-che?k-code (glob)

    13

  Skipping mercurial/httpclient/__init__.py it has no-che?k-code (glob)

    14

  Skipping mercurial/httpclient/_readers.py it has no-che?k-code (glob)

    15

  Skipping mercurial/httpclient/socketutil.py it has no-che?k-code (glob)