hg: obtain lock when creating share from pooled repo (issue5104) There are race conditions between clients performing a shared clone to pooled storage: 1) Clients race to create the new shared repo in the pool directory 2) 1 client is seeding the repo in the pool directory and another goes to share it before it is fully cloned We prevent these race conditions by obtaining a lock in the pool directory that is derived from the name of the repo we will be accessing. To test this, a simple generic "lockdelay" extension has been added. The extension inserts an optional, configurable delay before or after lock acquisition. In the test, we delay 2 seconds after lock acquisition in the first process and 1 second before lock acquisition in the 2nd process. This means the first process has 1s to obtain the lock. There is a race condition here. If we encounter it in the wild, we could change the dummy extension to wait on the lock file to appear instead of relying on timing. But that's more complicated. Let's see what happens first.

     1

syntax: glob

     2

     3

*.elc

     4

*.tmp

     5

*.orig

     6

*.rej

     7

*~

     8

*.mergebackup

     9

*.o

    10

*.so

    11

*.dll

    12

*.exe

    13

*.pyd

    14

*.pyc

    15

*.pyo

    16

*$py.class

    17

*.swp

    18

*.prof

    19

*.zip

    20

\#*\#

    21

.\#*

    22

tests/.coverage*

    23

tests/.testtimes*

    24

tests/annotated

    25

tests/*.err

    26

tests/htmlcov

    27

build

    28

contrib/hgsh/hgsh

    29

contrib/vagrant/.vagrant

    30

dist

    31

packages

    32

doc/common.txt

    33

doc/*.[0-9]

    34

doc/*.[0-9].txt

    35

doc/*.[0-9].gendoc.txt

    36

doc/*.[0-9].{x,ht}ml

    37

MANIFEST

    38

MANIFEST.in

    39

patches

    40

mercurial/__version__.py

    41

mercurial/hgpythonlib.h

    42

mercurial.egg-info

    43

.DS_Store

    44

tags

    45

cscope.*

    46

.idea/*

    47

i18n/hg.pot

    48

locale/*/LC_MESSAGES/hg.mo

    49

hgext/__index__.py

    50

    51

# files installed with a local --pure build

    52

mercurial/base85.py

    53

mercurial/bdiff.py

    54

mercurial/diffhelpers.py

    55

mercurial/mpatch.py

    56

mercurial/osutil.py

    57

mercurial/parsers.py

    58

    59

syntax: regexp

    60

^\.pc/

    61

^\.(pydev)?project

    62

    63

# hackable windows distribution additions

    64

^hg-python

    65

^hg.py$