manifest: tigher manifest parsing and flag use In the manifest line, flags are put directly after the hash, so the parser has been guessing the presence of flags based on the length of the hash. Replace this assumption by an enumeration of the valid flags and removing them from the hash first as they are distinct input values. Consistently handle the expected 256bit length of the SHA1-replacement in the pure Python parser. Check that setting flags will use one of the blessed values. Extend write logic in the C version to handle 256bit hashes as well. Verify that hashes always have exactly the expected length. Since 1070df141718 we should no longer depend on the old extra-byte hack. Differential Revision: https://phab.mercurial-scm.org/D8679

     1

{

     2

    // Enforcing

     3

    "eqeqeq"        : true,     // true: Require triple equals (===) for comparison

     4

    "forin"         : true,     // true: Require filtering for..in loops with obj.hasOwnProperty()

     5

    "freeze"        : true,     // true: prohibits overwriting prototypes of native objects such as Array, Date etc.

     6

    "nonbsp"        : true,     // true: Prohibit "non-breaking whitespace" characters.

     7

    "undef"         : true,     // true: Require all non-global variables to be declared (prevents global leaks)

     8

     9

    // Environments

    10

    "browser"       : true      // Web Browser (window, document, etc)

    11

}