bisect: avoid copying ancestor list for non-merge commits During a bisection, hg needs to compute a list of all ancestors for every candidate commit. This is accomplished via a bottom-up traversal of the set of candidates, during which each revision's ancestor list is populated using the ancestor list of its parent(s). Previously, this involved copying the entire list, which could be very long in if the bisection range was large. To help improve this, we can observe that each candidate commit is visited exactly once, at which point its ancestor list is copied into its children's lists and then dropped. In the case of non-merge commits, a commit's ancestor list consists exactly of its parent's list plus itself. This means that we can trivially reuse the parent's existing list for one of its non-merge children, which avoids copying entirely if that commit is the parent's only child. This makes bisections over linear ranges of commits much faster. During some informal testing in the large publicly-available `mozilla-central` repository, this noticeably sped up bisections over large ranges of history: Setup: $ cd mozilla-central $ hg bisect --reset $ hg bisect --good 0 $ hg log -r tip -T '{rev}\n' 628417 Test: $ time hg bisect --bad tip --noupdate Before: real 3m35.927s user 3m35.553s sys 0m0.319s After: real 1m41.142s user 1m40.810s sys 0m0.285s

     1

create verbosemmap.py

     2

  $ cat << EOF > verbosemmap.py

     3

  > # extension to make util.mmapread verbose

     4

  > 

     5

  > 

     6

  > from mercurial import (

     7

  >     extensions,

     8

  >     pycompat,

     9

  >     util,

    10

  > )

    11

  > 

    12

  > def extsetup(ui):

    13

  >     def mmapread(orig, fp):

    14

  >         ui.write(b"mmapping %s\n" % pycompat.bytestr(fp.name))

    15

  >         ui.flush()

    16

  >         return orig(fp)

    17

  > 

    18

  >     extensions.wrapfunction(util, 'mmapread', mmapread)

    19

  > EOF

    20

    21

setting up base repo

    22

  $ hg init a

    23

  $ cd a

    24

  $ touch a

    25

  $ hg add a

    26

  $ hg commit -qm base

    27

  $ for i in `$TESTDIR/seq.py 1 100` ; do

    28

  > echo $i > a

    29

  > hg commit -qm $i

    30

  > done

    31

    32

set up verbosemmap extension

    33

  $ cat << EOF >> $HGRCPATH

    34

  > [extensions]

    35

  > verbosemmap=$TESTTMP/verbosemmap.py

    36

  > EOF

    37

    38

mmap index which is now more than 4k long

    39

  $ hg log -l 5 -T '{rev}\n' --config experimental.mmapindexthreshold=4k

    40

  mmapping $TESTTMP/a/.hg/store/00changelog.i

    41

  100

    42

  99

    43

  98

    44

  97

    45

  96

    46

    47

do not mmap index which is still less than 32k

    48

  $ hg log -l 5 -T '{rev}\n' --config experimental.mmapindexthreshold=32k

    49

  100

    50

  99

    51

  98

    52

  97

    53

  96

    54

    55

  $ cd ..