bisect: avoid copying ancestor list for non-merge commits During a bisection, hg needs to compute a list of all ancestors for every candidate commit. This is accomplished via a bottom-up traversal of the set of candidates, during which each revision's ancestor list is populated using the ancestor list of its parent(s). Previously, this involved copying the entire list, which could be very long in if the bisection range was large. To help improve this, we can observe that each candidate commit is visited exactly once, at which point its ancestor list is copied into its children's lists and then dropped. In the case of non-merge commits, a commit's ancestor list consists exactly of its parent's list plus itself. This means that we can trivially reuse the parent's existing list for one of its non-merge children, which avoids copying entirely if that commit is the parent's only child. This makes bisections over linear ranges of commits much faster. During some informal testing in the large publicly-available `mozilla-central` repository, this noticeably sped up bisections over large ranges of history: Setup: $ cd mozilla-central $ hg bisect --reset $ hg bisect --good 0 $ hg log -r tip -T '{rev}\n' 628417 Test: $ time hg bisect --bad tip --noupdate Before: real 3m35.927s user 3m35.553s sys 0m0.319s After: real 1m41.142s user 1m40.810s sys 0m0.285s

     1

  $ hg init a

     2

  $ cd a

     3

  $ echo a > a

     4

  $ hg ci -Am0

     5

  adding a

     6

  $ echo b > b

     7

  $ hg ci -Am1

     8

  adding b

     9

  $ hg tag -r0 default

    10

  warning: tag default conflicts with existing branch name

    11

  $ hg log

    12

  changeset:   2:30a83d1e4a1e

    13

  tag:         tip

    14

  user:        test

    15

  date:        Thu Jan 01 00:00:00 1970 +0000

    16

  summary:     Added tag default for changeset f7b1eb17ad24

    17

    18

  changeset:   1:925d80f479bb

    19

  user:        test

    20

  date:        Thu Jan 01 00:00:00 1970 +0000

    21

  summary:     1

    22

    23

  changeset:   0:f7b1eb17ad24

    24

  tag:         default

    25

  user:        test

    26

  date:        Thu Jan 01 00:00:00 1970 +0000

    27

  summary:     0

    28

    29

  $ hg update 'tag(default)'

    30

  0 files updated, 0 files merged, 2 files removed, 0 files unresolved

    31

  $ hg parents

    32

  changeset:   0:f7b1eb17ad24

    33

  tag:         default

    34

  user:        test

    35

  date:        Thu Jan 01 00:00:00 1970 +0000

    36

  summary:     0

    37

    38

  $ hg update 'branch(default)'

    39

  2 files updated, 0 files merged, 0 files removed, 0 files unresolved

    40

  $ hg parents

    41

  changeset:   2:30a83d1e4a1e

    42

  tag:         tip

    43

  user:        test

    44

  date:        Thu Jan 01 00:00:00 1970 +0000

    45

  summary:     Added tag default for changeset f7b1eb17ad24

    46

    47

    48

  $ cd ..