bisect: avoid copying ancestor list for non-merge commits During a bisection, hg needs to compute a list of all ancestors for every candidate commit. This is accomplished via a bottom-up traversal of the set of candidates, during which each revision's ancestor list is populated using the ancestor list of its parent(s). Previously, this involved copying the entire list, which could be very long in if the bisection range was large. To help improve this, we can observe that each candidate commit is visited exactly once, at which point its ancestor list is copied into its children's lists and then dropped. In the case of non-merge commits, a commit's ancestor list consists exactly of its parent's list plus itself. This means that we can trivially reuse the parent's existing list for one of its non-merge children, which avoids copying entirely if that commit is the parent's only child. This makes bisections over linear ranges of commits much faster. During some informal testing in the large publicly-available `mozilla-central` repository, this noticeably sped up bisections over large ranges of history: Setup: $ cd mozilla-central $ hg bisect --reset $ hg bisect --good 0 $ hg log -r tip -T '{rev}\n' 628417 Test: $ time hg bisect --bad tip --noupdate Before: real 3m35.927s user 3m35.553s sys 0m0.319s After: real 1m41.142s user 1m40.810s sys 0m0.285s

     1

Minimal hgk check

     2

     3

  $ echo "[extensions]" >> $HGRCPATH

     4

  $ echo "hgk=" >> $HGRCPATH

     5

  $ hg init repo

     6

  $ cd repo

     7

  $ echo a > a

     8

  $ hg ci -Am adda

     9

  adding a

    10

  $ hg debug-cat-file commit 0

    11

  tree a0c8bcbbb45c

    12

  parent 000000000000

    13

  author test 0 0

    14

  revision 0

    15

  branch default

    16

  phase draft

    17

    18

  adda

    19

  $ echo b > b

    20

  $ hg ci -Am addb

    21

  adding b

    22

  $ hg log -T '{node}\n'

    23

  102a90ea7b4a3361e4082ed620918c261189a36a

    24

  07f4944404050f47db2e5c5071e0e84e7a27bba9

    25

    26

  $ hg debug-diff-tree 07f494440405 102a90ea7b4a

    27

  :000000 100664 000000000000 1e88685f5dde N	b	b

    28

  $ hg debug-diff-tree 07f494440405 102a90ea7b4a --patch

    29

  diff --git a/b b/b

    30

  new file mode 100644

    31

  --- /dev/null

    32

  +++ b/b

    33

  @@ -0,0 +1,1 @@

    34

  +b

    35

    36

Ensure that diff-tree output isn't affected by diffopts

    37

  $ hg --config diff.noprefix=True debug-diff-tree 07f494440405 102a90ea7b4a

    38

  :000000 100664 000000000000 1e88685f5dde N	b	b

    39

  $ hg --config diff.noprefix=True debug-diff-tree --patch 07f494440405 102a90ea7b4a

    40

  diff --git a/b b/b

    41

  new file mode 100644

    42

  --- /dev/null

    43

  +++ b/b

    44

  @@ -0,0 +1,1 @@

    45

  +b

    46

    47

  $ cd ..