bisect: avoid copying ancestor list for non-merge commits During a bisection, hg needs to compute a list of all ancestors for every candidate commit. This is accomplished via a bottom-up traversal of the set of candidates, during which each revision's ancestor list is populated using the ancestor list of its parent(s). Previously, this involved copying the entire list, which could be very long in if the bisection range was large. To help improve this, we can observe that each candidate commit is visited exactly once, at which point its ancestor list is copied into its children's lists and then dropped. In the case of non-merge commits, a commit's ancestor list consists exactly of its parent's list plus itself. This means that we can trivially reuse the parent's existing list for one of its non-merge children, which avoids copying entirely if that commit is the parent's only child. This makes bisections over linear ranges of commits much faster. During some informal testing in the large publicly-available `mozilla-central` repository, this noticeably sped up bisections over large ranges of history: Setup: $ cd mozilla-central $ hg bisect --reset $ hg bisect --good 0 $ hg log -r tip -T '{rev}\n' 628417 Test: $ time hg bisect --bad tip --noupdate Before: real 3m35.927s user 3m35.553s sys 0m0.319s After: real 1m41.142s user 1m40.810s sys 0m0.285s

     1

% removeancestorsfrom(), example 1

     2

remaining (sorted): [5, 6, 8, 9]

     3

% removeancestorsfrom(), example 2

     4

remaining (sorted): [11, 12, 13, 14]

     5

% removeancestorsfrom(), example 3

     6

remaining (sorted): [3, 5]

     7

% missingancestors(), example 1

     8

return [3, 7, 11]

     9

% missingancestors(), example 2

    10

return [5, 10]

    11

% missingancestors(), example 3

    12

return [3, 6, 9, 11]

    13

% removeancestorsfrom(), bigger graph

    14

Ok

    15

% lazy ancestor set for [], stoprev = 0, inclusive = False

    16

membership: []

    17

iteration:  []

    18

% lazy ancestor set for [11, 13], stoprev = 0, inclusive = False

    19

membership: [7, 8, 3, 4, 1, 0]

    20

iteration:  [8, 7, 4, 3, 2, 1, 0]

    21

% lazy ancestor set for [1, 3], stoprev = 0, inclusive = False

    22

membership: [1, 0]

    23

iteration:  [1, 0]

    24

% lazy ancestor set for [11, 13], stoprev = 0, inclusive = True

    25

membership: [11, 13, 7, 8, 3, 4, 1, 0]

    26

iteration:  [13, 11, 8, 7, 4, 3, 2, 1, 0]

    27

% lazy ancestor set for [11, 13], stoprev = 6, inclusive = False

    28

membership: [7, 8]

    29

iteration:  [8, 7]

    30

% lazy ancestor set for [11, 13], stoprev = 6, inclusive = True

    31

membership: [11, 13, 7, 8]

    32

iteration:  [13, 11, 8, 7]

    33

% lazy ancestor set for [11, 13], stoprev = 11, inclusive = True

    34

membership: [11, 13]

    35

iteration:  [13, 11]

    36

% lazy ancestor set for [11, 13], stoprev = 12, inclusive = True

    37

membership: [13]

    38

iteration:  [13]

    39

% lazy ancestor set for [10, 1], stoprev = 0, inclusive = True

    40

membership: [2, 10, 4, 5, 0, 1]

    41

iteration:  [10, 5, 4, 2, 1, 0]