dirstate: clean up when restoring identical backups When a dirstate backup is restored, it is possible that no actual changes to the dirstate have been made. In this case, the backup is still a hardlink to the original dirstate. Unfortunately, `os.rename` silently fails (nothing happens, and no error occurs) when `src` and `dst` are hardlinks to the same file. As a result, the backup is left lying around. Over time, these files accumulate. When restoring dirstate backups, check if the backup and the dirstate are the same file, and if so, just delete the backup. Differential Revision: https://phab.mercurial-scm.org/D1201

     1

Set up

     2

     3

  $ hg init repo

     4

  $ cd repo

     5

     6

Try to import an empty patch

     7

     8

  $ hg import --no-commit - <<EOF

     9

  > EOF

    10

  applying patch from stdin

    11

  abort: stdin: no diffs found

    12

  [255]

    13

    14

No dirstate backups are left behind

    15

    16

  $ ls .hg/dirstate* | sort

    17

  .hg/dirstate

    18