tests: replace "cp -r" with "cp -R" The POSIX documentation about "cp" [1] says: .... RATIONALE .... Earlier versions of this standard included support for the -r option to copy file hierarchies. The -r option is historical practice on BSD and BSD-derived systems. This option is no longer specified by POSIX.1-2008 but may be present in some implementations. The -R option was added as a close synonym to the -r option, selected for consistency with all other options in this volume of POSIX.1-2008 that do recursive directory descent. The difference between -R and the removed -r option is in the treatment by cp of file types other than regular and directory. It was implementation-defined how the - option treated special files to allow both historical implementations and those that chose to support -r with the same abilities as -R defined by this volume of POSIX.1-2008. The original -r flag, for historic reasons, did not handle special files any differently from regular files, but always read the file and copied its contents. This had obvious problems in the presence of special file types; for example, character devices, FIFOs, and sockets. .... .... Issue 6 The -r option is marked obsolescent. .... Issue 7 .... The obsolescent -r option is removed. .... (No "Issue 8" yet) Therefore it's clear that "cp -R" is strictly better than "cp -r". The issue was discovered when running tests on OS X after 0d87b1caed92. [1]: pubs.opengroup.org/onlinepubs/9699919799/utilities/cp.html

     1

     2

  $ cat > engine.py << EOF

     3

  > 

     4

  > from mercurial import templater

     5

  > 

     6

  > class mytemplater(object):

     7

  >     def __init__(self, loader, filters, defaults, aliases):

     8

  >         self.loader = loader

     9

  > 

    10

  >     def process(self, t, map):

    11

  >         tmpl = self.loader(t)

    12

  >         for k, v in map.iteritems():

    13

  >             if k in ('templ', 'ctx', 'repo', 'revcache', 'cache'):

    14

  >                 continue

    15

  >             if hasattr(v, '__call__'):

    16

  >                 v = v(**map)

    17

  >             v = templater.stringify(v)

    18

  >             tmpl = tmpl.replace('{{%s}}' % k, v)

    19

  >         yield tmpl

    20

  > 

    21

  > templater.engines['my'] = mytemplater

    22

  > EOF

    23

  $ hg init test

    24

  $ echo '[extensions]' > test/.hg/hgrc

    25

  $ echo "engine = `pwd`/engine.py" >> test/.hg/hgrc

    26

  $ cd test

    27

  $ cat > mymap << EOF

    28

  > changeset = my:changeset.txt

    29

  > EOF

    30

  $ cat > changeset.txt << EOF

    31

  > {{rev}} {{node}} {{author}}

    32

  > EOF

    33

  $ hg ci -Ama

    34

  adding changeset.txt

    35

  adding mymap

    36

  $ hg log --style=./mymap

    37

  0 97e5f848f0936960273bbf75be6388cd0350a32b test

    38

    39

  $ cat > changeset.txt << EOF

    40

  > {{p1rev}} {{p1node}} {{p2rev}} {{p2node}}

    41

  > EOF

    42

  $ hg ci -Ama

    43

  $ hg log --style=./mymap

    44

  0 97e5f848f0936960273bbf75be6388cd0350a32b -1 0000000000000000000000000000000000000000

    45

  -1 0000000000000000000000000000000000000000 -1 0000000000000000000000000000000000000000

    46

    47

invalid engine type:

    48

    49

  $ echo 'changeset = unknown:changeset.txt' > unknownenginemap

    50

  $ hg log --style=./unknownenginemap

    51

  abort: invalid template engine: unknown

    52

  [255]

    53

    54

  $ cd ..